aboutsummaryrefslogtreecommitdiff
path: root/clang/lib/Sema/DeclSpec.cpp
diff options
context:
space:
mode:
authorHuan Nguyen <nhuhuan@yahoo.com>2022-09-28 19:25:52 +0200
committerAmir Ayupov <aaupov@fb.com>2022-09-28 19:26:17 +0200
commit153eeb4a5e68c6054a220667646b14f3785a942e (patch)
treeb1ab80b0a3c0e51edd6a1edc763342ff395eb4dd /clang/lib/Sema/DeclSpec.cpp
parent12357e88af669b00a5c4c607b93b716a6c474846 (diff)
downloadllvm-153eeb4a5e68c6054a220667646b14f3785a942e.zip
llvm-153eeb4a5e68c6054a220667646b14f3785a942e.tar.gz
llvm-153eeb4a5e68c6054a220667646b14f3785a942e.tar.bz2
[BOLT] Disable -lite when split function is present
In lite mode, BOLT only transforms a subset of functions, leave the remaining functions intact. For NoPIC, it is fine. BOLT can scan relocations and fix-up all refs that point to any function body in the subset. For no-split function PIC, it is fine. Since jump tables are intra- procedural transfer, BOLT can find both the jump table base and the target within same function. Thus, BOLT can update and/or move jump tables. However, it is wrong to process a subset of functions in split function PIC. This is because BOLT does not know if functions in the subset are isolated, i.e., cannot be accessed by functions out of the subset, especially via split jump table. For example, BOLT only process three functions A, B and C. Suppose that A is reached via jump table from A.cold, which is not processed. When A is moved (due to optimization), the jump table in A.cold is invalid. We cannot fix-up this jump table since it is only recognized in A.cold, which BOLT does not process. Solution: Disable lite mode if split function is present. Future improvement: In lite mode, if split function is found, BOLT processes both functions in the subset and all of their sibling fragments. Test Plan: ``` ninja check-bolt ``` Reviewed By: Amir, maksfb Differential Revision: https://reviews.llvm.org/D131283
Diffstat (limited to 'clang/lib/Sema/DeclSpec.cpp')
0 files changed, 0 insertions, 0 deletions