diff options
| author | Marco Elver <elver@google.com> | 2025-02-16 12:42:06 +0100 |
|---|---|---|
| committer | Marco Elver <elver@google.com> | 2025-02-26 16:34:33 +0100 |
| commit | de10e44b6fe7f3d3cfde3afd8e1222d251172ade (patch) | |
| tree | 59669623b492a4a5f3cc45ee8c1a8620e45356a9 /clang/lib/Sema/AnalysisBasedWarnings.cpp | |
| parent | 3c8c0d4d8d9bbc160d160e683f7a74fd28574dc6 (diff) | |
| download | llvm-de10e44b6fe7f3d3cfde3afd8e1222d251172ade.zip llvm-de10e44b6fe7f3d3cfde3afd8e1222d251172ade.tar.gz llvm-de10e44b6fe7f3d3cfde3afd8e1222d251172ade.tar.bz2 | |
Thread Safety Analysis: Support warning on passing/returning pointers to guarded variables
Introduce `-Wthread-safety-pointer` to warn when passing or returning
pointers to guarded variables or guarded data. This is is analogous to
`-Wthread-safety-reference`, which performs similar checks for C++
references.
Adding checks for pointer passing is required to avoid false negatives
in large C codebases, where data structures are typically implemented
through helpers that take pointers to instances of a data structure.
The feature is planned to be enabled by default under `-Wthread-safety`
in the next release cycle. This gives time for early adopters to address
new findings.
Pull Request: https://github.com/llvm/llvm-project/pull/127396
Diffstat (limited to 'clang/lib/Sema/AnalysisBasedWarnings.cpp')
| -rw-r--r-- | clang/lib/Sema/AnalysisBasedWarnings.cpp | 24 |
1 files changed, 24 insertions, 0 deletions
diff --git a/clang/lib/Sema/AnalysisBasedWarnings.cpp b/clang/lib/Sema/AnalysisBasedWarnings.cpp index afdc0ea..3d6da4f7 100644 --- a/clang/lib/Sema/AnalysisBasedWarnings.cpp +++ b/clang/lib/Sema/AnalysisBasedWarnings.cpp @@ -1977,6 +1977,18 @@ class ThreadSafetyReporter : public clang::threadSafety::ThreadSafetyHandler { case POK_PtReturnByRef: DiagID = diag::warn_pt_guarded_return_by_reference; break; + case POK_PassPointer: + DiagID = diag::warn_guarded_pass_pointer; + break; + case POK_PtPassPointer: + DiagID = diag::warn_pt_guarded_pass_pointer; + break; + case POK_ReturnPointer: + DiagID = diag::warn_guarded_return_pointer; + break; + case POK_PtReturnPointer: + DiagID = diag::warn_pt_guarded_return_pointer; + break; } PartialDiagnosticAt Warning(Loc, S.PDiag(DiagID) << Kind << D @@ -2013,6 +2025,18 @@ class ThreadSafetyReporter : public clang::threadSafety::ThreadSafetyHandler { case POK_PtReturnByRef: DiagID = diag::warn_pt_guarded_return_by_reference; break; + case POK_PassPointer: + DiagID = diag::warn_guarded_pass_pointer; + break; + case POK_PtPassPointer: + DiagID = diag::warn_pt_guarded_pass_pointer; + break; + case POK_ReturnPointer: + DiagID = diag::warn_guarded_return_pointer; + break; + case POK_PtReturnPointer: + DiagID = diag::warn_pt_guarded_return_pointer; + break; } PartialDiagnosticAt Warning(Loc, S.PDiag(DiagID) << Kind << D |