diff options
| author | Yutong Zhu <115899167+YutongZhuu@users.noreply.github.com> | 2025-05-09 19:11:28 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-05-10 01:11:28 +0200 |
| commit | 2da57f8105f0faff5cb7d671307f7cfc7ff2dce4 (patch) | |
| tree | ab31e5e181e49309a45cc450784ddb82739bf333 /clang/lib/Sema/AnalysisBasedWarnings.cpp | |
| parent | 8836d68a0d5cac03b975057417936fe18cb9ccb1 (diff) | |
| download | llvm-2da57f8105f0faff5cb7d671307f7cfc7ff2dce4.zip llvm-2da57f8105f0faff5cb7d671307f7cfc7ff2dce4.tar.gz llvm-2da57f8105f0faff5cb7d671307f7cfc7ff2dce4.tar.bz2 | |
[Clang] Improve `-Wtautological-overlap-compare` diagnostics flag (#133653)
This PR attempts to improve the diagnostics flag
`-Wtautological-overlap-compare` (#13473). I have added code to warn
about float-point literals and character literals. I have also changed
the warning message for the non-overlapping case to provide a more
correct hint to the user.
Fixes #13473.
Diffstat (limited to 'clang/lib/Sema/AnalysisBasedWarnings.cpp')
| -rw-r--r-- | clang/lib/Sema/AnalysisBasedWarnings.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/clang/lib/Sema/AnalysisBasedWarnings.cpp b/clang/lib/Sema/AnalysisBasedWarnings.cpp index 2418aaf..d95844c 100644 --- a/clang/lib/Sema/AnalysisBasedWarnings.cpp +++ b/clang/lib/Sema/AnalysisBasedWarnings.cpp @@ -166,13 +166,14 @@ public: S.Diag(B->getExprLoc(), DiagID) << DiagRange; } - void compareAlwaysTrue(const BinaryOperator *B, bool isAlwaysTrue) override { + void compareAlwaysTrue(const BinaryOperator *B, + bool isAlwaysTrueOrFalse) override { if (HasMacroID(B)) return; SourceRange DiagRange = B->getSourceRange(); S.Diag(B->getExprLoc(), diag::warn_tautological_overlap_comparison) - << DiagRange << isAlwaysTrue; + << DiagRange << isAlwaysTrueOrFalse; } void compareBitwiseEquality(const BinaryOperator *B, |