diff options
author | Alex Langford <alangford@apple.com> | 2024-01-08 10:51:00 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-01-08 10:51:00 -0800 |
commit | 07d6fbf8d80083470b4371f2ddabd656a9c317e6 (patch) | |
tree | c159847b6c23c884d3c76798f73b4ee753c2985b /clang/lib/Lex/ModuleMap.cpp | |
parent | eb42868f25665ba6301a94a30e9df33e0d6ae61f (diff) | |
download | llvm-07d6fbf8d80083470b4371f2ddabd656a9c317e6.zip llvm-07d6fbf8d80083470b4371f2ddabd656a9c317e6.tar.gz llvm-07d6fbf8d80083470b4371f2ddabd656a9c317e6.tar.bz2 |
[lldb][NFCI] Remove BreakpointIDList::InsertStringArray (#77161)
This abstraction is leaky and BreakpointIDList does not need to know
about CommandReturnObject.
Additionally, setting the CommandReturnObject inout param to a success
state does very little. The function returns immediately if the input
ArrayRef is empty, and reading
CommandObjectMultiwordBreakpoint::VerifyIDs more closely, the input is
always empty if the previous call to
BreakpointIDList::FindAndReplaceIDRanges failed. If the call was
successful, then the CommandReturnObject is already in a success state.
I have opted to remove the function altogether and inline the
functionality where it was used.
Diffstat (limited to 'clang/lib/Lex/ModuleMap.cpp')
0 files changed, 0 insertions, 0 deletions