diff options
author | Jan Svoboda <jan_svoboda@apple.com> | 2025-04-11 08:20:12 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-04-11 08:20:12 -0700 |
commit | 5a41fc28f3b3f32a70fd5d81c2e33d10b3225806 (patch) | |
tree | 1400bf6572ef53488fd4fc26c26616bfe5f0843c /clang/lib/Frontend/CreateInvocationFromCommandLine.cpp | |
parent | 76b85d3a27d9de4667cdf6de158111830724f34d (diff) | |
download | llvm-5a41fc28f3b3f32a70fd5d81c2e33d10b3225806.zip llvm-5a41fc28f3b3f32a70fd5d81c2e33d10b3225806.tar.gz llvm-5a41fc28f3b3f32a70fd5d81c2e33d10b3225806.tar.bz2 |
[clang][modules] Name the module map files on PCM file conflict (#134475)
With implicitly-built modules, seeing something like:
```
fatal error: module 'X' is defined in both '<cache>/HASH1/X-HASH2.pcm' and '<cache>/HASH1/X-HASH3.pcm'
```
is super confusing and not actionable, because the module cache tends to
be hidden from the developer.
This PR adds a note to that diagnostic that names the module map files
the PCM files were compiled from, hopefully giving a good enough hint
for further investigation:
```
note: compiled from '<build>/X.framework/Modules/module.modulemap' and '<SDK>/X.framework/Modules/module.modulemap'
```
(I had to replace the mechanism used to convert `DiagnosticError` into
something `DiagnosticsEngine` can understand, because it seemingly did
not support notes.)
Diffstat (limited to 'clang/lib/Frontend/CreateInvocationFromCommandLine.cpp')
0 files changed, 0 insertions, 0 deletions