aboutsummaryrefslogtreecommitdiff
path: root/clang/lib/Frontend/CompilerInvocation.cpp
diff options
context:
space:
mode:
authorMax Kazantsev <mkazantsev@azul.com>2020-07-17 14:01:59 +0700
committerMax Kazantsev <mkazantsev@azul.com>2020-07-17 14:04:58 +0700
commitc98988107868db41c12b9d782fae25dea2a81c87 (patch)
tree42276e9f036db9b2beb0a09a7de325bf67fb5a02 /clang/lib/Frontend/CompilerInvocation.cpp
parent4905536086ee47f26cd13d716eff8aa6424dfdd7 (diff)
downloadllvm-c98988107868db41c12b9d782fae25dea2a81c87.zip
llvm-c98988107868db41c12b9d782fae25dea2a81c87.tar.gz
llvm-c98988107868db41c12b9d782fae25dea2a81c87.tar.bz2
[InstCombine] Fix replace select with Phis when branch has the same labels
``` define i32 @test(i1 %cond) { entry: br i1 %cond, label %exit, label %exit exit: %result = select i1 %cond, i32 123, i32 456 ret i32 %result } ``` In this test, after applying transformation of replacing select with Phis, the result will be: ``` define i32 @test(i1 %cond) { entry: br i1 %cond, label %exit, label %exit exit: %result = i32 phi [123, %exit], [123, %exit] ret i32 %result } ``` That is, select is transformed into an invalid Phi, which will then be reduced to 123 and the second value will be lost. But it is worth noting that this problem will arise only if select is in the InstCombine worklist will be before the branch. Otherwise, InstCombine will replace the branch condition with false and transformation will not be applied. The fix is to check the target labels in the branch condition for equality. Patch By: Kirill Polushin Differential Revision: https://reviews.llvm.org/D84003 Reviewed By: mkazantsev
Diffstat (limited to 'clang/lib/Frontend/CompilerInvocation.cpp')
0 files changed, 0 insertions, 0 deletions