diff options
| author | David Spickett <david.spickett@linaro.org> | 2020-09-24 14:50:41 +0100 |
|---|---|---|
| committer | David Spickett <david.spickett@linaro.org> | 2020-10-05 11:50:29 +0100 |
| commit | 71cf97e95b8c888367284d1d12925f79b38034eb (patch) | |
| tree | e7f77cc92d18c1f39d773626ac160965f0a2614a /clang/lib/Frontend/CompilerInvocation.cpp | |
| parent | 6a089ce0e40abbe4e0f26f05540e3caa60d98a29 (diff) | |
| download | llvm-71cf97e95b8c888367284d1d12925f79b38034eb.zip llvm-71cf97e95b8c888367284d1d12925f79b38034eb.tar.gz llvm-71cf97e95b8c888367284d1d12925f79b38034eb.tar.bz2 | |
Reland "[lldb] Don't send invalid region addresses to lldb server"
This reverts commit c65627a1fe3be7521fc232d633bb6df577f55269.
The test immediately after the new invalid symbol test was
failing on Windows. This was because when we called
VirtualQueryEx to get the region info for 0x0,
even if it succeeded we would call GetLastError.
Which must have picked up the last error that was set while
trying to lookup "not_an_address". Which happened to be 2.
("The system cannot find the file specified.")
To fix this only call GetLastError when we know VirtualQueryEx
has failed. (when it returns 0, which we were also checking for anyway)
Also convert memory region to an early return style
to make the logic clearer.
Reviewed By: labath, stella.stamenova
Differential Revision: https://reviews.llvm.org/D88229
Diffstat (limited to 'clang/lib/Frontend/CompilerInvocation.cpp')
0 files changed, 0 insertions, 0 deletions