diff options
| author | Adrian Vogelsgesang <avogelsgesang@salesforce.com> | 2023-02-01 17:39:27 -0800 |
|---|---|---|
| committer | Adrian Vogelsgesang <avogelsgesang@salesforce.com> | 2023-02-08 10:22:50 -0800 |
| commit | 54d4a2550d3167d51a9d386d9823a06aca459531 (patch) | |
| tree | 0f0f4ac6a8651c2846615d09c6a095c39d36d0bc /clang/lib/Frontend/CompilerInvocation.cpp | |
| parent | 604cc68b587d8b8a90bd1a0aecfbc7bd3021e926 (diff) | |
| download | llvm-54d4a2550d3167d51a9d386d9823a06aca459531.zip llvm-54d4a2550d3167d51a9d386d9823a06aca459531.tar.gz llvm-54d4a2550d3167d51a9d386d9823a06aca459531.tar.bz2 | |
[LLDB] Fix assertion failure by removing `CopyType` in `std::coroutine_handle` pretty printer
The pretty printer for `std::coroutine_handle` was running into
> Assertion failed: (target_ctx != source_ctx && "Can't import into itself")
from ClangASTImporter.h, line 270.
This commit fixes the issue by removing the `CopyType` call from the
pretty printer. While this call was necessary in the past, it seems to
be no longer required, at least all test cases are still passing. Maybe
something changed in the meantime around the handling of `TypesystemClang`
instances. I don't quite understand why `CopyType` was necessary earlier.
I am not sure how to add a regression test for this, though. It seems
the issue is already triggered by the exising `TestCoroutineHandle.py`,
but API tests seem to ignore all violations of `lldbassert` and still
report the test as "passed", even if assertions were triggered
Differential Revision: https://reviews.llvm.org/D143127
Diffstat (limited to 'clang/lib/Frontend/CompilerInvocation.cpp')
0 files changed, 0 insertions, 0 deletions