diff options
author | Andrew Rogers <andrurogerz@gmail.com> | 2025-06-16 11:03:48 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-06-16 11:03:48 -0700 |
commit | ffc4d87f9b2b57f7020fa5fd0f1d3003370c2d80 (patch) | |
tree | 8ac209a0321fc71f1320648d2d7d65691ad38fc7 /clang/lib/CodeGen/ModuleBuilder.cpp | |
parent | 4cd3e41bce449a10f431a3112b6cb8d7bc1b09cf (diff) | |
download | llvm-ffc4d87f9b2b57f7020fa5fd0f1d3003370c2d80.zip llvm-ffc4d87f9b2b57f7020fa5fd0f1d3003370c2d80.tar.gz llvm-ffc4d87f9b2b57f7020fa5fd0f1d3003370c2d80.tar.bz2 |
[llvm] annotate interfaces in Passes for DLL export (#143794)
## Purpose
This patch is one in a series of code-mods that annotate LLVM’s public
interface for export. This patch annotates the `llvm/Passes` library and
other pass-related headers. These annotations currently have no
meaningful impact on the LLVM build; however, they are a prerequisite to
support an LLVM Windows DLL (shared library) build.
## Background
This effort is tracked in #109483. Additional context is provided in
[this
discourse](https://discourse.llvm.org/t/psa-annotating-llvm-public-interface/85307),
and documentation for `LLVM_ABI` and related annotations is found in the
LLVM repo
[here](https://github.com/llvm/llvm-project/blob/main/llvm/docs/InterfaceExportAnnotations.rst).
The bulk of these changes were generated automatically using the
[Interface Definition Scanner (IDS)](https://github.com/compnerd/ids)
tool, followed formatting with `git clang-format`.
The following manual adjustments were also applied after running IDS on
Linux:
- Remove the redundant declaration of the `initializeKCFIPass` function
from llvm/include/llvm/InitializePasses.h because IDS only
auto-annotates the first declaration it encounters, and the second
un-annotated declaration results in an MSVC warning
- Add `LLVM_ABI` to a number of private `AnalysisKey` fields in classes
that extend the `AnalysisInfoMixin` template class.
- Add `LLVM_ABI` to the `ChangeReporter` and `TextChangeReporter`
template class definitions in
llvm/include/llvm/Passes/StandardInstrumentations.h and remove the
extern template instantiations. This is the only way I've found to get
everything compiling warning-free when building a DLL because both
template classes have methods implemented out-of-line.
## Validation
Local builds and tests to validate cross-platform compatibility. This
included llvm, clang, and lldb on the following configurations:
- Windows with MSVC
- Windows with Clang
- Linux with GCC
- Linux with Clang
- Darwin with Clang
Diffstat (limited to 'clang/lib/CodeGen/ModuleBuilder.cpp')
0 files changed, 0 insertions, 0 deletions