diff options
author | Hans Wennborg <hans@chromium.org> | 2025-03-12 16:18:07 +0100 |
---|---|---|
committer | Hans Wennborg <hans@chromium.org> | 2025-03-12 16:26:00 +0100 |
commit | e11ede5e90ee193dde179fe1a9ac9af718ede3db (patch) | |
tree | d719a4919d44cc8f4a5665a199a96bf98863b711 /clang/lib/CodeGen/CodeGenModule.h | |
parent | 90a8322399c7beb021cfe704003d36fafb1a7d29 (diff) | |
download | llvm-e11ede5e90ee193dde179fe1a9ac9af718ede3db.zip llvm-e11ede5e90ee193dde179fe1a9ac9af718ede3db.tar.gz llvm-e11ede5e90ee193dde179fe1a9ac9af718ede3db.tar.bz2 |
Revert "[MS][clang] Add support for vector deleting destructors (#126240)"
This caused link errors when building with sancov. See comment on the PR.
> Whereas it is UB in terms of the standard to delete an array of objects
> via pointer whose static type doesn't match its dynamic type, MSVC
> supports an extension allowing to do it.
> Aside from array deletion not working correctly in the mentioned case,
> currently not having this extension implemented causes clang to generate
> code that is not compatible with the code generated by MSVC, because
> clang always puts scalar deleting destructor to the vftable. This PR
> aims to resolve these problems.
>
> Fixes https://github.com/llvm/llvm-project/issues/19772
This reverts commit d6942d54f677000cf713d2b0eba57b641452beb4.
Diffstat (limited to 'clang/lib/CodeGen/CodeGenModule.h')
-rw-r--r-- | clang/lib/CodeGen/CodeGenModule.h | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/clang/lib/CodeGen/CodeGenModule.h b/clang/lib/CodeGen/CodeGenModule.h index e7c9238..6deb467 100644 --- a/clang/lib/CodeGen/CodeGenModule.h +++ b/clang/lib/CodeGen/CodeGenModule.h @@ -528,9 +528,6 @@ private: /// that we don't re-emit the initializer. llvm::DenseMap<const Decl*, unsigned> DelayedCXXInitPosition; - /// To remember which types did require a vector deleting dtor. - llvm::SmallPtrSet<const CXXRecordDecl *, 16> RequireVectorDeletingDtor; - typedef std::pair<OrderGlobalInitsOrStermFinalizers, llvm::Function *> GlobalInitData; @@ -1547,7 +1544,6 @@ public: void EmitGlobal(GlobalDecl D); bool TryEmitBaseDestructorAsAlias(const CXXDestructorDecl *D); - void EmitDefinitionAsAlias(GlobalDecl Alias, GlobalDecl Target); llvm::GlobalValue *GetGlobalValue(StringRef Ref); @@ -1815,8 +1811,6 @@ public: // behavior. So projects like the Linux kernel can rely on it. return !getLangOpts().CPlusPlus; } - void requireVectorDestructorDefinition(const CXXRecordDecl *RD); - bool classNeedsVectorDestructor(const CXXRecordDecl *RD); private: bool shouldDropDLLAttribute(const Decl *D, const llvm::GlobalValue *GV) const; |