diff options
| author | George Burgess IV <george.burgess.iv@gmail.com> | 2025-04-02 14:44:18 -0600 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-04-02 13:44:18 -0700 |
| commit | a8585654c2be671d78206666223dae28fe3ac511 (patch) | |
| tree | 3248e1e8643dae98ee8c7bdd57af0a984d0ddabe /clang/lib/CodeGen/CodeGenModule.cpp | |
| parent | 51d1c7288662ea801b07133fd2d22aff6bac50e2 (diff) | |
| download | llvm-a8585654c2be671d78206666223dae28fe3ac511.zip llvm-a8585654c2be671d78206666223dae28fe3ac511.tar.gz llvm-a8585654c2be671d78206666223dae28fe3ac511.tar.bz2 | |
[llvm][utils] skip revert-checking reverts across branches (#134108)
e2ba1b6ffde4ec607342b1b746d1b57f0f04390a references that it reverts a
commit that's not a parent of e2ba1b6ffde4ec607342b1b746d1b57f0f04390a.
Functionally, this can (and demonstrably does) work(*), but from the
standpoint of the revert checker, it's nonsense. Print a `logging.error`
when it's detected.
Tested by running the revert checker against a commit range that
includes the aforementioned commit; the logging.error was fired
appropriately.
(*) - the specifics here are:
- the _SHA_ that was referenced was on a non-main branch, but
- the commit from the non-main branch was merged into the non-main
branch from main
- ...so the _functional_ commit being reverted was originally landed on
main, but the _SHA_ referenced from main was from a branch that was cut
before the reverted-commit was landed on main
Diffstat (limited to 'clang/lib/CodeGen/CodeGenModule.cpp')
0 files changed, 0 insertions, 0 deletions