diff options
author | David Spickett <david.spickett@linaro.org> | 2025-06-13 14:23:02 +0000 |
---|---|---|
committer | David Spickett <david.spickett@linaro.org> | 2025-06-13 14:26:06 +0000 |
commit | 82911f188be7ce7cb0a04b7fd648ea8b4aad2e59 (patch) | |
tree | 2609d6dc2ed95ffc8f8da66054ff2f72d20016b3 /clang/lib/CodeGen/CodeGenFunction.cpp | |
parent | e6a3579653196af337f191ed2a3acbbf0e6d01bb (diff) | |
download | llvm-82911f188be7ce7cb0a04b7fd648ea8b4aad2e59.zip llvm-82911f188be7ce7cb0a04b7fd648ea8b4aad2e59.tar.gz llvm-82911f188be7ce7cb0a04b7fd648ea8b4aad2e59.tar.bz2 |
[lldb][test] Skip ReadAfterClose JSON Transport tests on Windows
These were failing on our Windows on Arm bot, or more precisely,
not even completing.
This is because Microsoft's C runtime does extra parameter validation.
So when we called _read with an invalid fd, it called an invalid
parameter handler instead of returning an error.
https://learn.microsoft.com/en-us/%20cpp/c-runtime-library/reference/read?view=msvc-170
https://learn.microsoft.com/en-us/%20cpp/c-runtime-library/parameter-validation?view=msvc-170
(lldb) run
Process 8440 launched: 'C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\tools\lldb\unittests\Host\HostTests.exe' (aarch64)
Process 8440 stopped
* thread #1, stop reason = Exception 0xc0000409 encountered at address 0x7ffb7453564c
frame #0: 0x00007ffb7453564c ucrtbase.dll`_get_thread_local_invalid_parameter_handler + 652
ucrtbase.dll`_get_thread_local_invalid_parameter_handler:
-> 0x7ffb7453564c <+652>: brk #0xf003
ucrtbase.dll`_invalid_parameter_noinfo:
0x7ffb74535650 <+0>: b 0x7ffb745354d8 ; _get_thread_local_invalid_parameter_handler + 280
0x7ffb74535654 <+4>: nop
0x7ffb74535658 <+8>: nop
You can override this handler but I'm assuming that this reading
after close isn't a crucial feature, so disabling the tests seems
like the way to go.
If it is crucial, we can check the fd before we use it.
Tests added by https://github.com/llvm/llvm-project/pull/143946.
Diffstat (limited to 'clang/lib/CodeGen/CodeGenFunction.cpp')
0 files changed, 0 insertions, 0 deletions