diff options
| author | Timm Baeder <tbaeder@redhat.com> | 2025-05-29 13:02:50 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-05-29 13:02:50 +0200 |
| commit | 4efe7a590d336b99f3b15e3b9cbe3c9a4ab9715f (patch) | |
| tree | e3fd31b1d199c7e12611e69395c839fd19a5903e /clang/lib/AST/ByteCode/Interp.cpp | |
| parent | 6769a836e97d5a09b239f78a8fd63cf4dac1fe13 (diff) | |
| download | llvm-4efe7a590d336b99f3b15e3b9cbe3c9a4ab9715f.zip llvm-4efe7a590d336b99f3b15e3b9cbe3c9a4ab9715f.tar.gz llvm-4efe7a590d336b99f3b15e3b9cbe3c9a4ab9715f.tar.bz2 | |
[clang][bytecode] Simplify diagnoseUnknownDecl if we're not diagnosing (#141910)
See the added comment.
This improves compile times a bit:
https://llvm-compile-time-tracker.com/compare.php?from=ac62f73f19ae9fb415d3fc423949b8d7543e8717&to=0d6cf47197a4ee11cdd1ee4a48ea38a2907c3d45&stat=instructions:u
Diffstat (limited to 'clang/lib/AST/ByteCode/Interp.cpp')
| -rw-r--r-- | clang/lib/AST/ByteCode/Interp.cpp | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/clang/lib/AST/ByteCode/Interp.cpp b/clang/lib/AST/ByteCode/Interp.cpp index a8286dd..fd86d70 100644 --- a/clang/lib/AST/ByteCode/Interp.cpp +++ b/clang/lib/AST/ByteCode/Interp.cpp @@ -136,6 +136,10 @@ static void diagnoseNonConstVariable(InterpState &S, CodePtr OpPC, const ValueDecl *VD); static bool diagnoseUnknownDecl(InterpState &S, CodePtr OpPC, const ValueDecl *D) { + // This function tries pretty hard to produce a good diagnostic. Just skip + // tha if nobody will see it anyway. + if (!S.diagnosing()) + return false; if (isa<ParmVarDecl>(D)) { if (D->getType()->isReferenceType()) @@ -168,6 +172,9 @@ static bool diagnoseUnknownDecl(InterpState &S, CodePtr OpPC, static void diagnoseNonConstVariable(InterpState &S, CodePtr OpPC, const ValueDecl *VD) { + if (!S.diagnosing()) + return; + const SourceInfo &Loc = S.Current->getSource(OpPC); if (!S.getLangOpts().CPlusPlus) { S.FFDiag(Loc); |