diff options
| author | Salman Javed <mail@salmanjaved.org> | 2021-11-30 12:43:35 +1300 |
|---|---|---|
| committer | Salman Javed <mail@salmanjaved.org> | 2021-11-30 12:43:35 +1300 |
| commit | c7aa358798e6330593fd5cc2ff4caf6bc15ba3c9 (patch) | |
| tree | 30c344f5e41b5b3f165ac2e9e068825f779ca13b /clang-tools-extra/unittests/clang-tidy/LLVMModuleTest.cpp | |
| parent | 0eee844539e406dfa8010a129ea3655d2298ac10 (diff) | |
| download | llvm-c7aa358798e6330593fd5cc2ff4caf6bc15ba3c9.zip llvm-c7aa358798e6330593fd5cc2ff4caf6bc15ba3c9.tar.gz llvm-c7aa358798e6330593fd5cc2ff4caf6bc15ba3c9.tar.bz2 | |
[clang-tidy] Fix pr48613: "llvm-header-guard uses a reserved identifier"
Fixes https://bugs.llvm.org/show_bug.cgi?id=48613.
llvm-header-guard is suggesting header guards with leading underscores
if the header file path begins with a '/' or similar special character.
Only reserved identifiers should begin with an underscore.
Differential Revision: https://reviews.llvm.org/D114149
Diffstat (limited to 'clang-tools-extra/unittests/clang-tidy/LLVMModuleTest.cpp')
| -rw-r--r-- | clang-tools-extra/unittests/clang-tidy/LLVMModuleTest.cpp | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/clang-tools-extra/unittests/clang-tidy/LLVMModuleTest.cpp b/clang-tools-extra/unittests/clang-tidy/LLVMModuleTest.cpp index 6b31241..2a3fae0 100644 --- a/clang-tools-extra/unittests/clang-tidy/LLVMModuleTest.cpp +++ b/clang-tools-extra/unittests/clang-tidy/LLVMModuleTest.cpp @@ -219,6 +219,16 @@ TEST(LLVMHeaderGuardCheckTest, FixHeaderGuards) { "", "/llvm-project/clang-tools-extra/clangd/foo.h", StringRef("header is missing header guard"))); + // Substitution of characters should not result in a header guard starting + // with "_". + EXPECT_EQ("#ifndef BAR_H\n" + "#define BAR_H\n" + "\n" + "\n" + "#endif\n", + runHeaderGuardCheck("", "include/--bar.h", + StringRef("header is missing header guard"))); + #ifdef WIN32 // Check interaction with Windows-style path separators (\). EXPECT_EQ( |