diff options
author | Piotr Zegar <me@piotrzegar.pl> | 2023-09-03 18:40:18 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-09-03 18:40:18 +0200 |
commit | fa8e74073762300d07b02adec42c629daf82c44b (patch) | |
tree | 7f8a4bc6898de3a13539d719b4b317758e3e882d /clang-tools-extra/test/clang-tidy/checkers/readability | |
parent | a0b0d7493db64d897ef68b43636810cfcb12bd22 (diff) | |
download | llvm-fa8e74073762300d07b02adec42c629daf82c44b.zip llvm-fa8e74073762300d07b02adec42c629daf82c44b.tar.gz llvm-fa8e74073762300d07b02adec42c629daf82c44b.tar.bz2 |
[clang-tidy] readability-identifier-naming - fix StructCase and UnionCase in C (#65202)
In C struct are visible as RecordDecl, not as CXXRecordDecl, this type
of declaration were not supported in this check before. Changing check
to support it. Added tests.
Fixes: #55422
Diffstat (limited to 'clang-tools-extra/test/clang-tidy/checkers/readability')
3 files changed, 16 insertions, 4 deletions
diff --git a/clang-tools-extra/test/clang-tidy/checkers/readability/Inputs/identifier-naming/hungarian-notation1/.clang-tidy b/clang-tools-extra/test/clang-tidy/checkers/readability/Inputs/identifier-naming/hungarian-notation1/.clang-tidy index fb68fa5..ff41479 100644 --- a/clang-tools-extra/test/clang-tidy/checkers/readability/Inputs/identifier-naming/hungarian-notation1/.clang-tidy +++ b/clang-tools-extra/test/clang-tidy/checkers/readability/Inputs/identifier-naming/hungarian-notation1/.clang-tidy @@ -1,6 +1,8 @@ Checks: readability-identifier-naming CheckOptions: readability-identifier-naming.AbstractClassCase: CamelCase + readability-identifier-naming.StructCase: CamelCase + readability-identifier-naming.UnionCase: camelBack readability-identifier-naming.ClassCase: CamelCase readability-identifier-naming.ClassConstantCase: CamelCase readability-identifier-naming.ClassMemberCase: CamelCase diff --git a/clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming-hungarian-notation-c-language.c b/clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming-hungarian-notation-c-language.c index abd7e1b..dd82c11 100644 --- a/clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming-hungarian-notation-c-language.c +++ b/clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming-hungarian-notation-c-language.c @@ -63,9 +63,14 @@ struct MyStruct { int StructCase; }; // CHECK-MESSAGES: :[[@LINE-1]]:23: warning: invalid case style for public member 'StructCase' [readability-identifier-naming] // CHECK-FIXES: {{^}}struct MyStruct { int iStructCase; }; +struct shouldBeCamelCaseStruct { int iField; }; +// CHECK-MESSAGES: :[[@LINE-1]]:8: warning: invalid case style for struct 'shouldBeCamelCaseStruct' [readability-identifier-naming] +// CHECK-FIXES: {{^}}struct ShouldBeCamelCaseStruct { int iField; }; + union MyUnion { int UnionCase; long lUnionCase; }; -// CHECK-MESSAGES: :[[@LINE-1]]:21: warning: invalid case style for public member 'UnionCase' [readability-identifier-naming] -// CHECK-FIXES: {{^}}union MyUnion { int iUnionCase; long lUnionCase; }; +// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: invalid case style for union 'MyUnion' [readability-identifier-naming] +// CHECK-MESSAGES: :[[@LINE-2]]:21: warning: invalid case style for public member 'UnionCase' [readability-identifier-naming] +// CHECK-FIXES: {{^}}union myUnion { int iUnionCase; long lUnionCase; }; //===----------------------------------------------------------------------===// // C string diff --git a/clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming-hungarian-notation.cpp b/clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming-hungarian-notation.cpp index 10feff3..b974fae 100644 --- a/clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming-hungarian-notation.cpp +++ b/clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming-hungarian-notation.cpp @@ -115,9 +115,14 @@ struct MyStruct { int StructCase; }; // CHECK-MESSAGES: :[[@LINE-1]]:23: warning: invalid case style for public member 'StructCase' [readability-identifier-naming] // CHECK-FIXES: {{^}}struct MyStruct { int iStructCase; }; +struct shouldBeCamelCaseStruct { int iField; }; +// CHECK-MESSAGES: :[[@LINE-1]]:8: warning: invalid case style for struct 'shouldBeCamelCaseStruct' [readability-identifier-naming] +// CHECK-FIXES: {{^}}struct ShouldBeCamelCaseStruct { int iField; }; + union MyUnion { int UnionCase; long lUnionCase; }; -// CHECK-MESSAGES: :[[@LINE-1]]:21: warning: invalid case style for public member 'UnionCase' [readability-identifier-naming] -// CHECK-FIXES: {{^}}union MyUnion { int iUnionCase; long lUnionCase; }; +// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: invalid case style for union 'MyUnion' [readability-identifier-naming] +// CHECK-MESSAGES: :[[@LINE-2]]:21: warning: invalid case style for public member 'UnionCase' [readability-identifier-naming] +// CHECK-FIXES: {{^}}union myUnion { int iUnionCase; long lUnionCase; }; //===----------------------------------------------------------------------===// // C string |