diff options
| author | vabridgers <58314289+vabridgers@users.noreply.github.com> | 2023-09-17 14:00:57 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-09-17 14:00:57 -0500 |
| commit | 4b5366c9512aa273a5272af1d833961e1ed156e7 (patch) | |
| tree | 34304f8cf0e5247c3e5bd1aa40127fcdfba08cd4 /clang-tools-extra/test/clang-tidy/checkers/readability | |
| parent | e6a007f6b51a661ed3dd8b0210b734b3e9b4354f (diff) | |
| download | llvm-4b5366c9512aa273a5272af1d833961e1ed156e7.zip llvm-4b5366c9512aa273a5272af1d833961e1ed156e7.tar.gz llvm-4b5366c9512aa273a5272af1d833961e1ed156e7.tar.bz2 | |
[clang-tidy] Avoid checking magic numbers if _BitInt (#65888)
Recent changes to add _BitInt support have caused our internal random
testing to fail. This change just avoids a readability magic numbers
check for now if a _BitInt. The crash seen (edited for clarity) is shown
below.
<src-root>/llvm/include/llvm/ADT/APInt.h:1488:
uint64_t llvm::APInt::getZExtValue() const: Assertion `getActiveBits()
<= 64 && "Too many bits for uint64_t"' failed.
...
#9 <address> llvm::APInt::getZExtValue() const
<src-root>/llvm/include/llvm/ADT/APInt.h:1488:5
clang::IntegerLiteral const*) const
<src-root>/clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp:198:47
<clang::IntegerLiteral>(clang::ast_matchers::MatchFinder::MatchResult
const&, char const*)
<src-root>/clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.h:67:5
clang::ast_matchers::MatchFinder::MatchResult const&)
<src-root>/clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp:152:35
...
Reviewed By: donat.nagy
Diffstat (limited to 'clang-tools-extra/test/clang-tidy/checkers/readability')
| -rw-r--r-- | clang-tools-extra/test/clang-tidy/checkers/readability/bitint-no-crash.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/clang-tools-extra/test/clang-tidy/checkers/readability/bitint-no-crash.c b/clang-tools-extra/test/clang-tidy/checkers/readability/bitint-no-crash.c new file mode 100644 index 0000000..f866092 --- /dev/null +++ b/clang-tools-extra/test/clang-tidy/checkers/readability/bitint-no-crash.c @@ -0,0 +1,6 @@ +// RUN: %check_clang_tidy %s readability-magic-numbers %t -- + +// Don't crash + +_BitInt(128) A = 4533629751480627964421wb; +// CHECK-MESSAGES: warning |