aboutsummaryrefslogtreecommitdiff
path: root/clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp
diff options
context:
space:
mode:
authorCongcong Cai <congcongcai0907@163.com>2023-09-07 17:06:28 +0800
committerGitHub <noreply@github.com>2023-09-07 17:06:28 +0800
commit31ded495271e5869d619da851a351c9f6f05b2d4 (patch)
tree3282cd228a8b30308097bd3bd90cb2254b935edb /clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp
parent741c1278175b9354442cd2143e1452714dc020a2 (diff)
downloadllvm-31ded495271e5869d619da851a351c9f6f05b2d4.zip
llvm-31ded495271e5869d619da851a351c9f6f05b2d4.tar.gz
llvm-31ded495271e5869d619da851a351c9f6f05b2d4.tar.bz2
[clang-tidy][modernize-use-using]fix function pointer typedef correctly (#65558)
Fixed #65055 For normal type, typedef is from typedef to the end of original type, but for function pointer it is from typedef to the end. So it needs to consider alias name length for normal type.
Diffstat (limited to 'clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp')
-rw-r--r--clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp6
1 files changed, 4 insertions, 2 deletions
diff --git a/clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp b/clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp
index c1af8b5..22dc9e2 100644
--- a/clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp
+++ b/clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp
@@ -120,8 +120,10 @@ void UseUsingCheck::check(const MatchFinder::MatchResult &Result) {
Type.substr(0, FirstTypedefType.size()) == FirstTypedefType)
Type = FirstTypedefName + Type.substr(FirstTypedefType.size() + 1);
}
- if (!ReplaceRange.getEnd().isMacroID())
- LastReplacementEnd = ReplaceRange.getEnd().getLocWithOffset(Name.size());
+ if (!ReplaceRange.getEnd().isMacroID()) {
+ const SourceLocation::IntTy Offset = MatchedDecl->getFunctionType() ? 0 : Name.size();
+ LastReplacementEnd = ReplaceRange.getEnd().getLocWithOffset(Offset);
+ }
auto Diag = diag(ReplaceRange.getBegin(), UseUsingWarning);