diff options
| author | Maksim Panchenko <maks@fb.com> | 2024-06-18 12:33:37 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-06-18 12:33:37 -0700 |
| commit | ad2905e52c2016a7de02ace59e33c3ca6ab53cd9 (patch) | |
| tree | c4e74ec29916c2cb639da0b7a845003bc128e115 /bolt/test | |
| parent | 0863bd83e573f5e3e35c5c6b5750ac74f2295f48 (diff) | |
| download | llvm-ad2905e52c2016a7de02ace59e33c3ca6ab53cd9.zip llvm-ad2905e52c2016a7de02ace59e33c3ca6ab53cd9.tar.gz llvm-ad2905e52c2016a7de02ace59e33c3ca6ab53cd9.tar.bz2 | |
[BOLT] Skip optimization of functions with alt instructions (#95172)
Alternative instructions in the Linux kernel may modify control flow in
a function. As such, it is unsafe to optimize functions with alternative
instructions until we properly support CFG alternatives.
Previously, we marked functions with alt instructions before the
emission, but that could be too late if we remove or replace
instructions with alternatives. We could have marked functions as
non-simple immediately after reading .altinstructions, but it's nice to
be able to view functions after CFG is built. Thus assign the non-simple
status after building CFG.
Diffstat (limited to 'bolt/test')
| -rw-r--r-- | bolt/test/X86/linux-alt-instruction.s | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/bolt/test/X86/linux-alt-instruction.s b/bolt/test/X86/linux-alt-instruction.s index 66cd33a..dc1b12a2 100644 --- a/bolt/test/X86/linux-alt-instruction.s +++ b/bolt/test/X86/linux-alt-instruction.s @@ -6,7 +6,7 @@ # RUN: llvm-mc -filetype=obj -triple x86_64-unknown-unknown %s -o %t.o # RUN: %clang %cflags -nostdlib %t.o -o %t.exe \ # RUN: -Wl,--image-base=0xffffffff80000000,--no-dynamic-linker,--no-eh-frame-hdr,--no-pie -# RUN: llvm-bolt %t.exe --print-normalized --alt-inst-feature-size=2 -o %t.out \ +# RUN: llvm-bolt %t.exe --print-cfg --alt-inst-feature-size=2 -o %t.out \ # RUN: | FileCheck %s ## Older kernels used to have padlen field in alt_instr. Check compatibility. @@ -15,7 +15,7 @@ # RUN: %s -o %t.padlen.o # RUN: %clang %cflags -nostdlib %t.padlen.o -o %t.padlen.exe \ # RUN: -Wl,--image-base=0xffffffff80000000,--no-dynamic-linker,--no-eh-frame-hdr,--no-pie -# RUN: llvm-bolt %t.padlen.exe --print-normalized --alt-inst-has-padlen -o %t.padlen.out \ +# RUN: llvm-bolt %t.padlen.exe --print-cfg --alt-inst-has-padlen -o %t.padlen.out \ # RUN: | FileCheck %s ## Check with a larger size of "feature" field in alt_instr. @@ -24,7 +24,7 @@ # RUN: --defsym FEATURE_SIZE_4=1 %s -o %t.fs4.o # RUN: %clang %cflags -nostdlib %t.fs4.o -o %t.fs4.exe \ # RUN: -Wl,--image-base=0xffffffff80000000,--no-dynamic-linker,--no-eh-frame-hdr,--no-pie -# RUN: llvm-bolt %t.fs4.exe --print-normalized --alt-inst-feature-size=4 -o %t.fs4.out \ +# RUN: llvm-bolt %t.fs4.exe --print-cfg --alt-inst-feature-size=4 -o %t.fs4.out \ # RUN: | FileCheck %s ## Check that out-of-bounds read is handled properly. @@ -33,9 +33,9 @@ ## Check that BOLT automatically detects structure fields in .altinstructions. -# RUN: llvm-bolt %t.exe --print-normalized -o %t.out | FileCheck %s -# RUN: llvm-bolt %t.exe --print-normalized -o %t.padlen.out | FileCheck %s -# RUN: llvm-bolt %t.exe --print-normalized -o %t.fs4.out | FileCheck %s +# RUN: llvm-bolt %t.exe --print-cfg -o %t.out | FileCheck %s +# RUN: llvm-bolt %t.exe --print-cfg -o %t.padlen.out | FileCheck %s +# RUN: llvm-bolt %t.exe --print-cfg -o %t.fs4.out | FileCheck %s # CHECK: BOLT-INFO: Linux kernel binary detected # CHECK: BOLT-INFO: parsed 2 alternative instruction entries |