diff options
| author | Eisuke Kawashima <e.kawaschima+github@gmail.com> | 2024-06-07 19:03:07 +0900 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-06-07 12:03:07 +0200 |
| commit | fd45dcca26d6031fcbaa907d8d6c0d9755b36699 (patch) | |
| tree | 1a2263daddbdd26f29945d6dcef9ae5f8823238d | |
| parent | af3ffff34fb39cfb1e19dce68bd1c3fefda336a4 (diff) | |
| download | llvm-fd45dcca26d6031fcbaa907d8d6c0d9755b36699.zip llvm-fd45dcca26d6031fcbaa907d8d6c0d9755b36699.tar.gz llvm-fd45dcca26d6031fcbaa907d8d6c0d9755b36699.tar.bz2 | |
fix(mlir/**.py): fix comparison to None (#94019)
from PEP8
(https://peps.python.org/pep-0008/#programming-recommendations):
> Comparisons to singletons like None should always be done with is or
is not, never the equality operators.
Co-authored-by: Eisuke Kawashima <e-kwsm@users.noreply.github.com>
| -rw-r--r-- | mlir/test/python/ir/affine_expr.py | 2 | ||||
| -rw-r--r-- | mlir/test/python/ir/attributes.py | 8 | ||||
| -rw-r--r-- | mlir/test/python/ir/builtin_types.py | 8 |
3 files changed, 9 insertions, 9 deletions
diff --git a/mlir/test/python/ir/affine_expr.py b/mlir/test/python/ir/affine_expr.py index 6356430..c7861c1 100644 --- a/mlir/test/python/ir/affine_expr.py +++ b/mlir/test/python/ir/affine_expr.py @@ -42,7 +42,7 @@ def testAffineExprEq(): # CHECK: False print(a1 == a3) # CHECK: False - print(a1 == None) + print(a1 is None) # CHECK: False print(a1 == "foo") diff --git a/mlir/test/python/ir/attributes.py b/mlir/test/python/ir/attributes.py index dbd6bad..0f2c8e7 100644 --- a/mlir/test/python/ir/attributes.py +++ b/mlir/test/python/ir/attributes.py @@ -56,8 +56,8 @@ def testAttrEq(): print("a1 == a2:", a1 == a2) # CHECK: a1 == a3: True print("a1 == a3:", a1 == a3) - # CHECK: a1 == None: False - print("a1 == None:", a1 == None) + # CHECK: a1 is None: False + print("a1 is None:", a1 is None) # CHECK-LABEL: TEST: testAttrHash @@ -109,9 +109,9 @@ def testAttrEqDoesNotRaise(): # CHECK: False print(a1 == not_an_attr) # CHECK: False - print(a1 == None) + print(a1 is None) # CHECK: True - print(a1 != None) + print(a1 is not None) # CHECK-LABEL: TEST: testAttrCapsule diff --git a/mlir/test/python/ir/builtin_types.py b/mlir/test/python/ir/builtin_types.py index 4eea1a9..cfe377c 100644 --- a/mlir/test/python/ir/builtin_types.py +++ b/mlir/test/python/ir/builtin_types.py @@ -57,8 +57,8 @@ def testTypeEq(): print("t1 == t2:", t1 == t2) # CHECK: t1 == t3: True print("t1 == t3:", t1 == t3) - # CHECK: t1 == None: False - print("t1 == None:", t1 == None) + # CHECK: t1 is None: False + print("t1 is None:", t1 is None) # CHECK-LABEL: TEST: testTypeHash @@ -143,9 +143,9 @@ def testTypeEqDoesNotRaise(): # CHECK: False print(t1 == not_a_type) # CHECK: False - print(t1 == None) + print(t1 is None) # CHECK: True - print(t1 != None) + print(t1 is not None) # CHECK-LABEL: TEST: testTypeCapsule |