diff options
author | Owen Pan <owenpiano@gmail.com> | 2024-02-16 23:19:31 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-02-16 23:19:31 -0800 |
commit | ea16a3bb4ce4010e3e15fddaad03df66f99548c6 (patch) | |
tree | e84f9a100ac7db4b2b9eab207c8b0ad103e1740b | |
parent | 3da01663313803530a936aee7ecc592534aeb380 (diff) | |
download | llvm-ea16a3bb4ce4010e3e15fddaad03df66f99548c6.zip llvm-ea16a3bb4ce4010e3e15fddaad03df66f99548c6.tar.gz llvm-ea16a3bb4ce4010e3e15fddaad03df66f99548c6.tar.bz2 |
[clang-format] Don't sort qualifiers across preprocessor directives (#81958)
Fixes #80579.
-rw-r--r-- | clang/lib/Format/QualifierAlignmentFixer.cpp | 2 | ||||
-rw-r--r-- | clang/unittests/Format/QualifierFixerTest.cpp | 13 |
2 files changed, 15 insertions, 0 deletions
diff --git a/clang/lib/Format/QualifierAlignmentFixer.cpp b/clang/lib/Format/QualifierAlignmentFixer.cpp index 8494174..0c63d33 100644 --- a/clang/lib/Format/QualifierAlignmentFixer.cpp +++ b/clang/lib/Format/QualifierAlignmentFixer.cpp @@ -561,6 +561,8 @@ void LeftRightQualifierAlignmentFixer::fixQualifierAlignment( for (const auto *Tok = First; Tok && Tok != Last && Tok->Next; Tok = Tok->Next) { + if (Tok->MustBreakBefore) + break; if (Tok->is(tok::comment)) continue; if (RightAlign) { diff --git a/clang/unittests/Format/QualifierFixerTest.cpp b/clang/unittests/Format/QualifierFixerTest.cpp index 0aa755a..43476ae 100644 --- a/clang/unittests/Format/QualifierFixerTest.cpp +++ b/clang/unittests/Format/QualifierFixerTest.cpp @@ -1177,6 +1177,19 @@ TEST_F(QualifierFixerTest, DontPushQualifierThroughNonSpecifiedTypes) { verifyFormat("const inline static Foo;", Style); } +TEST_F(QualifierFixerTest, QualifiersBrokenUpByPPDirectives) { + auto Style = getLLVMStyle(); + Style.QualifierAlignment = FormatStyle::QAS_Custom; + Style.QualifierOrder = {"constexpr", "inline", "type"}; + + verifyFormat("inline\n" + "#if FOO\n" + " constexpr\n" + "#endif\n" + " int i = 0;", + Style); +} + TEST_F(QualifierFixerTest, UnsignedQualifier) { FormatStyle Style = getLLVMStyle(); |