aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarek Kurdej <marek.kurdej+llvm.org@gmail.com>2022-02-09 21:58:22 +0100
committerMarek Kurdej <marek.kurdej+llvm.org@gmail.com>2022-02-09 22:15:20 +0100
commite329b5866f1732f5c24cf2ae96479971f7101914 (patch)
tree5ca68eb742ae605e28d061dc482e148b9c8e3bac
parente6d9bab558655e5cbb556fdff816aae10f50917a (diff)
downloadllvm-e329b5866f1732f5c24cf2ae96479971f7101914.zip
llvm-e329b5866f1732f5c24cf2ae96479971f7101914.tar.gz
llvm-e329b5866f1732f5c24cf2ae96479971f7101914.tar.bz2
[clang-format] Honour "// clang-format off" when using QualifierOrder.
Fixes https://github.com/llvm/llvm-project/issues/53643. Reviewed By: MyDeveloperDay, HazardyKnusperkeks, owenpan Differential Revision: https://reviews.llvm.org/D119218
-rw-r--r--clang/lib/Format/QualifierAlignmentFixer.cpp4
-rwxr-xr-xclang/unittests/Format/QualifierFixerTest.cpp22
2 files changed, 26 insertions, 0 deletions
diff --git a/clang/lib/Format/QualifierAlignmentFixer.cpp b/clang/lib/Format/QualifierAlignmentFixer.cpp
index 13af32a9..233b081 100644
--- a/clang/lib/Format/QualifierAlignmentFixer.cpp
+++ b/clang/lib/Format/QualifierAlignmentFixer.cpp
@@ -390,6 +390,10 @@ LeftRightQualifierAlignmentFixer::analyze(
for (AnnotatedLine *Line : AnnotatedLines) {
FormatToken *First = Line->First;
+ assert(First);
+ if (First->Finalized)
+ continue;
+
const auto *Last = Line->Last;
for (const auto *Tok = First; Tok && Tok != Last && Tok->Next;
diff --git a/clang/unittests/Format/QualifierFixerTest.cpp b/clang/unittests/Format/QualifierFixerTest.cpp
index 0517de2..14f09d8 100755
--- a/clang/unittests/Format/QualifierFixerTest.cpp
+++ b/clang/unittests/Format/QualifierFixerTest.cpp
@@ -858,5 +858,27 @@ TEST_F(QualifierFixerTest, QualifierTemplates) {
Style);
}
+TEST_F(QualifierFixerTest, DisableRegions) {
+ FormatStyle Style = getLLVMStyle();
+ Style.QualifierAlignment = FormatStyle::QAS_Custom;
+ Style.QualifierOrder = {"inline", "static", "const", "type"};
+
+ ReplacementCount = 0;
+ verifyFormat("// clang-format off\n"
+ "int const inline static a = 0;\n"
+ "// clang-format on\n",
+ Style);
+ EXPECT_EQ(ReplacementCount, 0);
+ verifyFormat("// clang-format off\n"
+ "int const inline static a = 0;\n"
+ "// clang-format on\n"
+ "inline static const int a = 0;\n",
+ "// clang-format off\n"
+ "int const inline static a = 0;\n"
+ "// clang-format on\n"
+ "int const inline static a = 0;\n",
+ Style);
+}
+
} // namespace format
} // namespace clang