diff options
author | Simon Pilgrim <llvm-dev@redking.me.uk> | 2022-01-23 15:11:08 +0000 |
---|---|---|
committer | Simon Pilgrim <llvm-dev@redking.me.uk> | 2022-01-23 15:11:08 +0000 |
commit | d7aa402b4b8a325a68c20d0300ac6bc664766be0 (patch) | |
tree | 5f4d22298a8ba2a294fc8f4f312f27fe32c8234e | |
parent | c93491352cf3146559de7755283f0dd259392126 (diff) | |
download | llvm-d7aa402b4b8a325a68c20d0300ac6bc664766be0.zip llvm-d7aa402b4b8a325a68c20d0300ac6bc664766be0.tar.gz llvm-d7aa402b4b8a325a68c20d0300ac6bc664766be0.tar.bz2 |
[lldb] PdbAstBuilder - use cast<> instead of dyn_cast<> to avoid dereference of nullptr
The pointers are dereferenced immediately, so assert the cast is correct instead of returning nullptr
-rw-r--r-- | lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp b/lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp index 9473bef..dc0969a 100644 --- a/lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp +++ b/lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp @@ -1081,7 +1081,7 @@ PdbAstBuilder::GetOrCreateFunctionDecl(PdbCompilandSymId func_id) { clang::FunctionDecl *function_decl = nullptr; if (parent->isRecord()) { - clang::QualType parent_qt = llvm::dyn_cast<clang::TypeDecl>(parent) + clang::QualType parent_qt = llvm::cast<clang::TypeDecl>(parent) ->getTypeForDecl() ->getCanonicalTypeInternal(); lldb::opaque_compiler_type_t parent_opaque_ty = @@ -1318,7 +1318,7 @@ void PdbAstBuilder::ParseAllNamespacesPlusChildrenOf( if (!context->isNamespace()) continue; - clang::NamespaceDecl *ns = llvm::dyn_cast<clang::NamespaceDecl>(context); + clang::NamespaceDecl *ns = llvm::cast<clang::NamespaceDecl>(context); std::string actual_ns = ns->getQualifiedNameAsString(); if (llvm::StringRef(actual_ns).startswith(*parent)) { clang::QualType qt = GetOrCreateType(tid); |