diff options
author | Bruce Mitchener <bruce.mitchener@gmail.com> | 2015-10-07 16:48:33 +0000 |
---|---|---|
committer | Bruce Mitchener <bruce.mitchener@gmail.com> | 2015-10-07 16:48:33 +0000 |
commit | b8269c7228a6b25795b0bd414262b9e788a0f0e3 (patch) | |
tree | 467767f323a0780d89886b967945b6c86b3ef2a4 | |
parent | 30f07f9326101938f0dd3e5b55d0ba693f6ffecf (diff) | |
download | llvm-b8269c7228a6b25795b0bd414262b9e788a0f0e3.zip llvm-b8269c7228a6b25795b0bd414262b9e788a0f0e3.tar.gz llvm-b8269c7228a6b25795b0bd414262b9e788a0f0e3.tar.bz2 |
Remove unused virtuals from ABISysV_ppc*
Summary:
The StackUsesFrames and FunctionCallsChangeCFA virtual functions
aren't used anywhere and aren't overridden by anything.
They were introduced when the ABISysV_ppc* code was added and weren't
used at the time. The review for the commit that added them can be
found at http://reviews.llvm.org/D5988
The commit comment notes that backtraces don't yet work:
Backtraces don't work. This is due to PowerPC ABI using a
backchain pointer in memory, instead of a dedicated frame
pointer register for the backchain.
So there is a possibility these were added with the intent of using
them in the future.
Reviewers: clayborg, jingham, jhibbits, emaste
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D13506
llvm-svn: 249563
-rw-r--r-- | lldb/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h | 12 | ||||
-rw-r--r-- | lldb/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h | 12 |
2 files changed, 0 insertions, 24 deletions
diff --git a/lldb/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h b/lldb/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h index e680dec..12ee741 100644 --- a/lldb/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h +++ b/lldb/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h @@ -62,12 +62,6 @@ public: virtual bool RegisterIsVolatile (const lldb_private::RegisterInfo *reg_info); - virtual bool - StackUsesFrames () - { - return true; - } - // The SysV ppc ABI requires that stack frames be 16 byte aligned. // When there is a trap handler on the stack, e.g. _sigtramp in userland // code, we've seen that the stack pointer is often not aligned properly @@ -97,12 +91,6 @@ public: return true; } - virtual bool - FunctionCallsChangeCFA () - { - return true; - } - virtual const lldb_private::RegisterInfo * GetRegisterInfoArray (uint32_t &count); //------------------------------------------------------------------ diff --git a/lldb/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h b/lldb/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h index ad4c2b7..e89a73a 100644 --- a/lldb/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h +++ b/lldb/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h @@ -62,12 +62,6 @@ public: virtual bool RegisterIsVolatile (const lldb_private::RegisterInfo *reg_info); - virtual bool - StackUsesFrames () - { - return true; - } - // The SysV ppc64 ABI requires that stack frames be 16 byte aligned. // When there is a trap handler on the stack, e.g. _sigtramp in userland // code, we've seen that the stack pointer is often not aligned properly @@ -97,12 +91,6 @@ public: return true; } - virtual bool - FunctionCallsChangeCFA () - { - return true; - } - virtual const lldb_private::RegisterInfo * GetRegisterInfoArray (uint32_t &count); //------------------------------------------------------------------ |