diff options
| author | Jonas Devlieghere <jonas@devlieghere.com> | 2024-07-15 21:11:40 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-07-15 21:11:40 -0700 |
| commit | b3e1f1b13249868bef6a7c0895bcf2953eeabe44 (patch) | |
| tree | f5d42ce0825f57acbdfbdbe837406798a18191ff | |
| parent | 4497ec293a6e745be817dc88027169bd5e4f7246 (diff) | |
| download | llvm-b3e1f1b13249868bef6a7c0895bcf2953eeabe44.zip llvm-b3e1f1b13249868bef6a7c0895bcf2953eeabe44.tar.gz llvm-b3e1f1b13249868bef6a7c0895bcf2953eeabe44.tar.bz2 | |
[lldb] Fix help syntax for add-dsym (target symbols add) (#98976)
The help output incorrectly states that this command takes a shared
library name (<shlib-name>) while really it takes a path to a symbol
file.
rdar://131777043
| -rw-r--r-- | lldb/source/Commands/CommandObjectTarget.cpp | 2 | ||||
| -rw-r--r-- | lldb/test/Shell/SymbolFile/add-dsym.test | 3 |
2 files changed, 4 insertions, 1 deletions
diff --git a/lldb/source/Commands/CommandObjectTarget.cpp b/lldb/source/Commands/CommandObjectTarget.cpp index 80181a9..d594330 100644 --- a/lldb/source/Commands/CommandObjectTarget.cpp +++ b/lldb/source/Commands/CommandObjectTarget.cpp @@ -4252,7 +4252,7 @@ public: m_option_group.Append(&m_current_stack_option, LLDB_OPT_SET_2, LLDB_OPT_SET_2); m_option_group.Finalize(); - AddSimpleArgumentList(eArgTypeShlibName); + AddSimpleArgumentList(eArgTypeFilename); } ~CommandObjectTargetSymbolsAdd() override = default; diff --git a/lldb/test/Shell/SymbolFile/add-dsym.test b/lldb/test/Shell/SymbolFile/add-dsym.test index cdcba64..52d1a13 100644 --- a/lldb/test/Shell/SymbolFile/add-dsym.test +++ b/lldb/test/Shell/SymbolFile/add-dsym.test @@ -1,5 +1,8 @@ # REQUIRES: system-darwin +# RUN: %lldb -o 'help add-dsym' | FileCheck %s --check-prefix=HELP +# HELP: Syntax: add-dsym <cmd-options> <filename> + # RUN: yaml2obj %S/Inputs/a.yaml -o %t.out # RUN: LLDB_APPLE_DSYMFORUUID_EXECUTABLE=%S/Inputs/dsymforuuid.sh %lldb %t.out -o 'add-dsym -u 41945CA4-5D9D-3CDE-82B4-37E4C09750B5' 2>&1 | FileCheck %s # CHECK: UUID information was not found |