diff options
| author | Zequan Wu <zequanwu@google.com> | 2020-09-28 17:17:23 -0700 |
|---|---|---|
| committer | Zequan Wu <zequanwu@google.com> | 2020-09-29 09:49:51 -0700 |
| commit | a9abe1f7859e4e1293969a93213294584a5aaba9 (patch) | |
| tree | ed113471757e258b9b937f3db1be151b5d78148f | |
| parent | d2d7a44facd2dc895d378f19233837147f587b6d (diff) | |
| download | llvm-a9abe1f7859e4e1293969a93213294584a5aaba9.zip llvm-a9abe1f7859e4e1293969a93213294584a5aaba9.tar.gz llvm-a9abe1f7859e4e1293969a93213294584a5aaba9.tar.bz2 | |
[COFF][CG Profile] set undefined symbol to external
Differential Revision: https://reviews.llvm.org/D88456
| -rw-r--r-- | llvm/lib/MC/MCWinCOFFStreamer.cpp | 4 | ||||
| -rw-r--r-- | llvm/test/MC/COFF/cgprofile.s | 28 |
2 files changed, 4 insertions, 28 deletions
diff --git a/llvm/lib/MC/MCWinCOFFStreamer.cpp b/llvm/lib/MC/MCWinCOFFStreamer.cpp index d8fde40..520d4a0 100644 --- a/llvm/lib/MC/MCWinCOFFStreamer.cpp +++ b/llvm/lib/MC/MCWinCOFFStreamer.cpp @@ -340,10 +340,8 @@ void MCWinCOFFStreamer::finalizeCGProfileEntry(const MCSymbolRefExpr *&SRE) { const MCSymbol *S = &SRE->getSymbol(); bool Created; getAssembler().registerSymbol(*S, &Created); - if (Created) { - cast<MCSymbolCOFF>(S)->setIsWeakExternal(); + if (Created) cast<MCSymbolCOFF>(S)->setExternal(true); - } } void MCWinCOFFStreamer::finalizeCGProfile() { diff --git a/llvm/test/MC/COFF/cgprofile.s b/llvm/test/MC/COFF/cgprofile.s index a0c47a6..c2f9503 100644 --- a/llvm/test/MC/COFF/cgprofile.s +++ b/llvm/test/MC/COFF/cgprofile.s @@ -30,7 +30,7 @@ late3: # CHECK-NEXT: ] # CHECK-NEXT: SectionData ( # CHECK-NEXT: 0000: 0A000000 0E000000 20000000 00000000 -# CHECK-NEXT: 0010: 11000000 0A000000 0B000000 00000000 +# CHECK-NEXT: 0010: 0F000000 0A000000 0B000000 00000000 # CHECK-NEXT: 0020: 0B000000 0C000000 14000000 00000000 # CHECK-NEXT: ) @@ -68,37 +68,15 @@ late3: # CHECK-NEXT: Section: IMAGE_SYM_UNDEFINED # CHECK-NEXT: BaseType: # CHECK-NEXT: ComplexType: -# CHECK-NEXT: StorageClass: WeakExternal -# CHECK-NEXT: AuxSymbolCount: 1 -# CHECK-NEXT: AuxWeakExternal { -# CHECK-NEXT: Linked: .weak.b.default.late -# CHECK-NEXT: Search: Alias -# CHECK-NEXT: } -# CHECK: Name: .weak.b.default.late -# CHECK-NEXT: Value: -# CHECK-NEXT: Section: IMAGE_SYM_ABSOLUTE -# CHECK-NEXT: BaseType: -# CHECK-NEXT: ComplexType: # CHECK-NEXT: StorageClass: External -# CHECK-NEXT: AuxSymbolCount: 0 +# CHECK-NEXT: AuxSymbolCount: # CHECK: Name: freq # CHECK-NEXT: Value: # CHECK-NEXT: Section: IMAGE_SYM_UNDEFINED # CHECK-NEXT: BaseType: # CHECK-NEXT: ComplexType: -# CHECK-NEXT: StorageClass: WeakExternal -# CHECK-NEXT: AuxSymbolCount: 1 -# CHECK-NEXT: AuxWeakExternal { -# CHECK-NEXT: Linked: .weak.freq.default.late -# CHECK-NEXT: Search: Alias -# CHECK-NEXT: } -# CHECK: Name: .weak.freq.default.late -# CHECK-NEXT: Value: -# CHECK-NEXT: Section: IMAGE_SYM_ABSOLUTE -# CHECK-NEXT: BaseType: -# CHECK-NEXT: ComplexType: # CHECK-NEXT: StorageClass: External -# CHECK-NEXT: AuxSymbolCount: 0 +# CHECK-NEXT: AuxSymbolCount: # CHECK: CGProfile [ # CHECK-NEXT: CGProfileEntry { |