aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Klausler <pklausler@nvidia.com>2022-02-08 10:07:55 -0800
committerPeter Klausler <pklausler@nvidia.com>2022-02-14 15:34:45 -0800
commit882d5f14adabdf642510cfe8e4a002833f585dda (patch)
treea9307b673deffa568cd553830dc22a7a1f97c714
parent8de457eafc08f6f05dc70ecf0f3d461e35ba478f (diff)
downloadllvm-882d5f14adabdf642510cfe8e4a002833f585dda.zip
llvm-882d5f14adabdf642510cfe8e4a002833f585dda.tar.gz
llvm-882d5f14adabdf642510cfe8e4a002833f585dda.tar.bz2
[flang] Ensure a characterized ENTRY in a PURE subprogram is also marked PURE
ENTRY point symbols aren't marked PURE in the symbol table, but must instead inherit the attribute from their containing subprograms. There's a predicate in semantics that does this, but it wasn't being used in the context of actual procedure argument characterization. Differential Revision: https://reviews.llvm.org/D119564
-rw-r--r--flang/lib/Evaluate/characteristics.cpp12
1 files changed, 6 insertions, 6 deletions
diff --git a/flang/lib/Evaluate/characteristics.cpp b/flang/lib/Evaluate/characteristics.cpp
index fb2917a..c32c370 100644
--- a/flang/lib/Evaluate/characteristics.cpp
+++ b/flang/lib/Evaluate/characteristics.cpp
@@ -371,13 +371,13 @@ static std::optional<Procedure> CharacterizeProcedure(
seenProcs.insert(symbol);
CopyAttrs<Procedure, Procedure::Attr>(symbol, result,
{
- {semantics::Attr::PURE, Procedure::Attr::Pure},
{semantics::Attr::ELEMENTAL, Procedure::Attr::Elemental},
{semantics::Attr::BIND_C, Procedure::Attr::BindC},
});
- if (result.attrs.test(Procedure::Attr::Elemental) &&
- !symbol.attrs().test(semantics::Attr::IMPURE)) {
- result.attrs.set(Procedure::Attr::Pure); // explicitly flag pure procedures
+ if (IsPureProcedure(symbol) || // works for ENTRY too
+ (!symbol.attrs().test(semantics::Attr::IMPURE) &&
+ result.attrs.test(Procedure::Attr::Elemental))) {
+ result.attrs.set(Procedure::Attr::Pure);
}
return std::visit(
common::visitors{
@@ -809,8 +809,8 @@ std::optional<Procedure> Procedure::Characterize(
std::optional<Procedure> Procedure::Characterize(
const ProcedureDesignator &proc, FoldingContext &context) {
if (const auto *symbol{proc.GetSymbol()}) {
- if (auto result{characteristics::Procedure::Characterize(
- ResolveAssociations(*symbol), context)}) {
+ if (auto result{
+ characteristics::Procedure::Characterize(*symbol, context)}) {
return result;
}
} else if (const auto *intrinsic{proc.GetSpecificIntrinsic()}) {