diff options
| author | Dawn Perchik <dawn@burble.org> | 2015-06-25 17:45:53 +0000 |
|---|---|---|
| committer | Dawn Perchik <dawn@burble.org> | 2015-06-25 17:45:53 +0000 |
| commit | 6c506bdab29eb826d56fd1fb69a74f6a4e18292f (patch) | |
| tree | d9c4d82f8017b28d7a701c92e761db7edbf934d2 | |
| parent | 02c302790f5f3325626c21aef839fbcf28c95dc7 (diff) | |
| download | llvm-6c506bdab29eb826d56fd1fb69a74f6a4e18292f.zip llvm-6c506bdab29eb826d56fd1fb69a74f6a4e18292f.tar.gz llvm-6c506bdab29eb826d56fd1fb69a74f6a4e18292f.tar.bz2 | |
Rename Mangled::GetLanguage to Mangled::GuessLanguage
The language can not be definitively determined from the mangling, so
this new name helps clarify that fact. This addresses the concerns raised
in http://reviews.llvm.org/rL226962.
Reviewed by: clayborg
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D10723
llvm-svn: 240662
| -rw-r--r-- | lldb/include/lldb/Core/Mangled.h | 10 | ||||
| -rw-r--r-- | lldb/source/Core/Mangled.cpp | 2 |
2 files changed, 6 insertions, 6 deletions
diff --git a/lldb/include/lldb/Core/Mangled.h b/lldb/include/lldb/Core/Mangled.h index a307bac..67b8d68 100644 --- a/lldb/include/lldb/Core/Mangled.h +++ b/lldb/include/lldb/Core/Mangled.h @@ -298,12 +298,12 @@ public: SetValue (const ConstString &name); //---------------------------------------------------------------------- - /// Get the language only if it is definitive what the language is from - /// the mangling. + /// Try to guess the language from the mangling. /// /// For a mangled name to have a language it must have both a mangled - /// and a demangled name and it must be definitive from the mangling - /// what the language is. + /// and a demangled name and it can be guessed from the mangling what + /// the language is. Note: this will return C++ for any language that + /// uses Itanium ABI mangling. /// /// Standard C function names will return eLanguageTypeUnknown because /// they aren't mangled and it isn't clear what language the name @@ -314,7 +314,7 @@ public: /// if there is no mangled or demangled counterpart. //---------------------------------------------------------------------- lldb::LanguageType - GetLanguage (); + GuessLanguage (); private: //---------------------------------------------------------------------- diff --git a/lldb/source/Core/Mangled.cpp b/lldb/source/Core/Mangled.cpp index ae5481db..4ba320d 100644 --- a/lldb/source/Core/Mangled.cpp +++ b/lldb/source/Core/Mangled.cpp @@ -423,7 +423,7 @@ Mangled::MemorySize () const } lldb::LanguageType -Mangled::GetLanguage () +Mangled::GuessLanguage () { ConstString mangled = GetMangledName(); if (mangled) |