diff options
author | Fangrui Song <i@maskray.me> | 2024-06-29 17:26:51 -0700 |
---|---|---|
committer | Fangrui Song <i@maskray.me> | 2024-06-29 17:26:51 -0700 |
commit | 66518ad7fd3383d1f1b617914c0bc3437ac3a355 (patch) | |
tree | fa41f984be8bef154a57121083f99f1e96c6ef69 | |
parent | e5aef72c0af7fd8fcdde107e31444970d3fb87ea (diff) | |
download | llvm-66518ad7fd3383d1f1b617914c0bc3437ac3a355.zip llvm-66518ad7fd3383d1f1b617914c0bc3437ac3a355.tar.gz llvm-66518ad7fd3383d1f1b617914c0bc3437ac3a355.tar.bz2 |
[MC] Remove addFragment. NFC
This was introduced in dcb71c06c7b059e313f22e46bc9c41343a03f1eb to help
migrate away raw `operator new` and refactor the fragment
representation.
This is now unneeded after `MCStreamer::CurFrag` and
`MCSection::CurFragList` refactoring.
-rw-r--r-- | llvm/include/llvm/MC/MCSection.h | 12 | ||||
-rw-r--r-- | llvm/lib/MC/MCContext.cpp | 3 | ||||
-rw-r--r-- | llvm/lib/MC/MCMachOStreamer.cpp | 4 | ||||
-rw-r--r-- | llvm/lib/MC/MCWinCOFFStreamer.cpp | 4 |
4 files changed, 4 insertions, 19 deletions
diff --git a/llvm/include/llvm/MC/MCSection.h b/llvm/include/llvm/MC/MCSection.h index e8e6575..58ba34c 100644 --- a/llvm/include/llvm/MC/MCSection.h +++ b/llvm/include/llvm/MC/MCSection.h @@ -198,18 +198,6 @@ public: iterator end() const { return {}; } bool empty() const { return !CurFragList->Head; } - void addFragment(MCFragment &F) { - // The formal layout order will be finalized in MCAssembler::layout. - if (CurFragList->Tail) { - CurFragList->Tail->Next = &F; - F.setLayoutOrder(CurFragList->Tail->getLayoutOrder() + 1); - } else { - CurFragList->Head = &F; - assert(F.getLayoutOrder() == 0); - } - CurFragList->Tail = &F; - } - void dump() const; virtual void printSwitchToSection(const MCAsmInfo &MAI, const Triple &T, diff --git a/llvm/lib/MC/MCContext.cpp b/llvm/lib/MC/MCContext.cpp index 1f23705..2fe8369 100644 --- a/llvm/lib/MC/MCContext.cpp +++ b/llvm/lib/MC/MCContext.cpp @@ -201,7 +201,8 @@ MCDataFragment *MCContext::allocInitialFragment(MCSection &Sec) { assert(!Sec.curFragList()->Head); auto *F = allocFragment<MCDataFragment>(); F->setParent(&Sec); - Sec.addFragment(*F); + Sec.curFragList()->Head = F; + Sec.curFragList()->Tail = F; return F; } diff --git a/llvm/lib/MC/MCMachOStreamer.cpp b/llvm/lib/MC/MCMachOStreamer.cpp index e2f6508..d67b958 100644 --- a/llvm/lib/MC/MCMachOStreamer.cpp +++ b/llvm/lib/MC/MCMachOStreamer.cpp @@ -596,9 +596,7 @@ void MCMachOStreamer::createAddrSigSection() { MCSection *AddrSigSection = Asm.getContext().getObjectFileInfo()->getAddrSigSection(); changeSection(AddrSigSection); - auto *Frag = getContext().allocFragment<MCDataFragment>(); - Frag->setParent(AddrSigSection); - AddrSigSection->addFragment(*Frag); + auto *Frag = cast<MCDataFragment>(AddrSigSection->curFragList()->Head); // We will generate a series of pointer-sized symbol relocations at offset // 0x0. Set the section size to be large enough to contain a single pointer // (instead of emitting a zero-sized section) so these relocations are diff --git a/llvm/lib/MC/MCWinCOFFStreamer.cpp b/llvm/lib/MC/MCWinCOFFStreamer.cpp index c4c3570..538244c 100644 --- a/llvm/lib/MC/MCWinCOFFStreamer.cpp +++ b/llvm/lib/MC/MCWinCOFFStreamer.cpp @@ -205,9 +205,7 @@ void MCWinCOFFStreamer::emitCOFFSafeSEH(MCSymbol const *Symbol) { changeSection(SXData); SXData->ensureMinAlignment(Align(4)); - auto *F = getContext().allocFragment<MCSymbolIdFragment>(Symbol); - F->setParent(SXData); - SXData->addFragment(*F); + insert(getContext().allocFragment<MCSymbolIdFragment>(Symbol)); getAssembler().registerSymbol(*Symbol); CSymbol->setIsSafeSEH(); |