diff options
author | Fangrui Song <i@maskray.me> | 2024-07-01 18:17:05 -0700 |
---|---|---|
committer | Fangrui Song <i@maskray.me> | 2024-07-01 18:17:05 -0700 |
commit | 63ec52f867ada8d841dd872acf3d0cb62e2a99e8 (patch) | |
tree | f75286567ce0b0216a7c8f6eafce3005e78d3ec4 | |
parent | bbb50369a149d9a7d1f91efaaabf75c260a220c7 (diff) | |
download | llvm-63ec52f867ada8d841dd872acf3d0cb62e2a99e8.zip llvm-63ec52f867ada8d841dd872acf3d0cb62e2a99e8.tar.gz llvm-63ec52f867ada8d841dd872acf3d0cb62e2a99e8.tar.bz2 |
MCAssembler::layout: remove the unused MCAsmLayout parameter
Almost complete the MCAsmLayout removal work started by 67957a45ee1ec42ae1671cdbfa0d73127346cc95.
-rw-r--r-- | bolt/lib/Core/BinaryContext.cpp | 4 | ||||
-rw-r--r-- | llvm/include/llvm/MC/MCAssembler.h | 3 | ||||
-rw-r--r-- | llvm/lib/MC/MCAssembler.cpp | 7 | ||||
-rw-r--r-- | llvm/lib/MC/MCExpr.cpp | 1 | ||||
-rw-r--r-- | llvm/tools/dsymutil/MachOUtils.cpp | 4 |
5 files changed, 5 insertions, 14 deletions
diff --git a/bolt/lib/Core/BinaryContext.cpp b/bolt/lib/Core/BinaryContext.cpp index 3bd715d..f28a0cd 100644 --- a/bolt/lib/Core/BinaryContext.cpp +++ b/bolt/lib/Core/BinaryContext.cpp @@ -20,7 +20,6 @@ #include "llvm/DebugInfo/DWARF/DWARFCompileUnit.h" #include "llvm/DebugInfo/DWARF/DWARFFormValue.h" #include "llvm/DebugInfo/DWARF/DWARFUnit.h" -#include "llvm/MC/MCAsmLayout.h" #include "llvm/MC/MCAssembler.h" #include "llvm/MC/MCContext.h" #include "llvm/MC/MCDisassembler/MCDisassembler.h" @@ -2416,8 +2415,7 @@ BinaryContext::calculateEmittedSize(BinaryFunction &BF, bool FixBranches) { MCAssembler &Assembler = static_cast<MCObjectStreamer *>(Streamer.get())->getAssembler(); - MCAsmLayout Layout(Assembler); - Assembler.layout(Layout); + Assembler.layout(); // Obtain fragment sizes. std::vector<uint64_t> FragmentSizes; diff --git a/llvm/include/llvm/MC/MCAssembler.h b/llvm/include/llvm/MC/MCAssembler.h index df5ad0e..9cd65d3 100644 --- a/llvm/include/llvm/MC/MCAssembler.h +++ b/llvm/include/llvm/MC/MCAssembler.h @@ -46,7 +46,6 @@ class MCRelaxableFragment; class MCSymbolRefExpr; class raw_ostream; class MCAsmBackend; -class MCAsmLayout; class MCContext; class MCCodeEmitter; class MCFragment; @@ -341,7 +340,7 @@ public: void Finish(); // Layout all section and prepare them for emission. - void layout(MCAsmLayout &Layout); + void layout(); // FIXME: This does not belong here. bool getSubsectionsViaSymbols() const { return SubsectionsViaSymbols; } diff --git a/llvm/lib/MC/MCAssembler.cpp b/llvm/lib/MC/MCAssembler.cpp index 6866a58..4cafec6 100644 --- a/llvm/lib/MC/MCAssembler.cpp +++ b/llvm/lib/MC/MCAssembler.cpp @@ -15,7 +15,6 @@ #include "llvm/ADT/Twine.h" #include "llvm/MC/MCAsmBackend.h" #include "llvm/MC/MCAsmInfo.h" -#include "llvm/MC/MCAsmLayout.h" #include "llvm/MC/MCCodeEmitter.h" #include "llvm/MC/MCCodeView.h" #include "llvm/MC/MCContext.h" @@ -937,7 +936,7 @@ MCAssembler::handleFixup(MCFragment &F, const MCFixup &Fixup, return std::make_tuple(Target, FixedValue, IsResolved); } -void MCAssembler::layout(MCAsmLayout &Layout) { +void MCAssembler::layout() { assert(getBackendPtr() && "Expected assembler backend"); DEBUG_WITH_TYPE("mc-dump", { errs() << "assembler backend - pre-layout\n--\n"; @@ -1074,9 +1073,7 @@ void MCAssembler::layout(MCAsmLayout &Layout) { } void MCAssembler::Finish() { - // Create the layout object. - MCAsmLayout Layout(*this); - layout(Layout); + layout(); // Write the object file. stats::ObjectBytes += getWriter().writeObject(*this); diff --git a/llvm/lib/MC/MCExpr.cpp b/llvm/lib/MC/MCExpr.cpp index 0a175ade..b42a668 100644 --- a/llvm/lib/MC/MCExpr.cpp +++ b/llvm/lib/MC/MCExpr.cpp @@ -12,7 +12,6 @@ #include "llvm/Config/llvm-config.h" #include "llvm/MC/MCAsmBackend.h" #include "llvm/MC/MCAsmInfo.h" -#include "llvm/MC/MCAsmLayout.h" #include "llvm/MC/MCAssembler.h" #include "llvm/MC/MCContext.h" #include "llvm/MC/MCObjectWriter.h" diff --git a/llvm/tools/dsymutil/MachOUtils.cpp b/llvm/tools/dsymutil/MachOUtils.cpp index fba6630..d2bdcf8 100644 --- a/llvm/tools/dsymutil/MachOUtils.cpp +++ b/llvm/tools/dsymutil/MachOUtils.cpp @@ -12,7 +12,6 @@ #include "LinkUtils.h" #include "llvm/ADT/SmallString.h" #include "llvm/CodeGen/NonRelocatableStringpool.h" -#include "llvm/MC/MCAsmLayout.h" #include "llvm/MC/MCAssembler.h" #include "llvm/MC/MCMachObjectWriter.h" #include "llvm/MC/MCObjectStreamer.h" @@ -381,8 +380,7 @@ bool generateDsymCompanion( auto &Writer = static_cast<MachObjectWriter &>(MCAsm.getWriter()); // Layout but don't emit. - MCAsmLayout Layout(MCAsm); - MCAsm.layout(Layout); + MCAsm.layout(); BinaryHolder InputBinaryHolder(VFS, false); |