diff options
author | Matthias Springer <me@m-sp.org> | 2024-10-08 10:22:58 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-10-08 10:22:58 +0200 |
commit | 634c57d738e07754b63160b38e3639467c902cdb (patch) | |
tree | ab04c3646650f8dbb1ae65581ca586986407a8b3 | |
parent | 20b8d3f52b02679f8be0e043df0f1bfd48c0c2bf (diff) | |
download | llvm-634c57d738e07754b63160b38e3639467c902cdb.zip llvm-634c57d738e07754b63160b38e3639467c902cdb.tar.gz llvm-634c57d738e07754b63160b38e3639467c902cdb.tar.bz2 |
[mlir][SCF][NFC] `scf.for`/`scf.while`: rename builder args (#111493)
Rename builder args to make them consistent with the `args` in the
TableGen definition.
-rw-r--r-- | mlir/include/mlir/Dialect/SCF/IR/SCFOps.td | 4 | ||||
-rw-r--r-- | mlir/lib/Dialect/SCF/IR/SCF.cpp | 22 |
2 files changed, 13 insertions, 13 deletions
diff --git a/mlir/include/mlir/Dialect/SCF/IR/SCFOps.td b/mlir/include/mlir/Dialect/SCF/IR/SCFOps.td index 8470404..361f8e0 100644 --- a/mlir/include/mlir/Dialect/SCF/IR/SCFOps.td +++ b/mlir/include/mlir/Dialect/SCF/IR/SCFOps.td @@ -249,7 +249,7 @@ def ForOp : SCF_Op<"for", let skipDefaultBuilders = 1; let builders = [ OpBuilder<(ins "Value":$lowerBound, "Value":$upperBound, "Value":$step, - CArg<"ValueRange", "std::nullopt">:$iterArgs, + CArg<"ValueRange", "std::nullopt">:$initArgs, CArg<"function_ref<void(OpBuilder &, Location, Value, ValueRange)>", "nullptr">)> ]; @@ -1074,7 +1074,7 @@ def WhileOp : SCF_Op<"while", let regions = (region SizedRegion<1>:$before, SizedRegion<1>:$after); let builders = [ - OpBuilder<(ins "TypeRange":$resultTypes, "ValueRange":$operands, + OpBuilder<(ins "TypeRange":$resultTypes, "ValueRange":$inits, "function_ref<void(OpBuilder &, Location, ValueRange)>":$beforeBuilder, "function_ref<void(OpBuilder &, Location, ValueRange)>":$afterBuilder)> ]; diff --git a/mlir/lib/Dialect/SCF/IR/SCF.cpp b/mlir/lib/Dialect/SCF/IR/SCF.cpp index d1c9fd2..2582d4e 100644 --- a/mlir/lib/Dialect/SCF/IR/SCF.cpp +++ b/mlir/lib/Dialect/SCF/IR/SCF.cpp @@ -312,25 +312,25 @@ void ConditionOp::getSuccessorRegions( //===----------------------------------------------------------------------===// void ForOp::build(OpBuilder &builder, OperationState &result, Value lb, - Value ub, Value step, ValueRange iterArgs, + Value ub, Value step, ValueRange initArgs, BodyBuilderFn bodyBuilder) { OpBuilder::InsertionGuard guard(builder); result.addOperands({lb, ub, step}); - result.addOperands(iterArgs); - for (Value v : iterArgs) + result.addOperands(initArgs); + for (Value v : initArgs) result.addTypes(v.getType()); Type t = lb.getType(); Region *bodyRegion = result.addRegion(); Block *bodyBlock = builder.createBlock(bodyRegion); bodyBlock->addArgument(t, result.location); - for (Value v : iterArgs) + for (Value v : initArgs) bodyBlock->addArgument(v.getType(), v.getLoc()); // Create the default terminator if the builder is not provided and if the // iteration arguments are not provided. Otherwise, leave this to the caller // because we don't know which values to return from the loop. - if (iterArgs.empty() && !bodyBuilder) { + if (initArgs.empty() && !bodyBuilder) { ForOp::ensureTerminator(*bodyRegion, builder, result.location); } else if (bodyBuilder) { OpBuilder::InsertionGuard guard(builder); @@ -3260,23 +3260,23 @@ LogicalResult ReduceReturnOp::verify() { void WhileOp::build(::mlir::OpBuilder &odsBuilder, ::mlir::OperationState &odsState, TypeRange resultTypes, - ValueRange operands, BodyBuilderFn beforeBuilder, + ValueRange inits, BodyBuilderFn beforeBuilder, BodyBuilderFn afterBuilder) { - odsState.addOperands(operands); + odsState.addOperands(inits); odsState.addTypes(resultTypes); OpBuilder::InsertionGuard guard(odsBuilder); // Build before region. SmallVector<Location, 4> beforeArgLocs; - beforeArgLocs.reserve(operands.size()); - for (Value operand : operands) { + beforeArgLocs.reserve(inits.size()); + for (Value operand : inits) { beforeArgLocs.push_back(operand.getLoc()); } Region *beforeRegion = odsState.addRegion(); - Block *beforeBlock = odsBuilder.createBlock( - beforeRegion, /*insertPt=*/{}, operands.getTypes(), beforeArgLocs); + Block *beforeBlock = odsBuilder.createBlock(beforeRegion, /*insertPt=*/{}, + inits.getTypes(), beforeArgLocs); if (beforeBuilder) beforeBuilder(odsBuilder, odsState.location, beforeBlock->getArguments()); |