diff options
author | Aiden Grossman <aidengrossman@google.com> | 2025-05-26 20:06:25 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-05-26 20:06:25 +0000 |
commit | 5fc3e76ec4f323c22cddf7b9458137510507847a (patch) | |
tree | beed2ef789e7c558aaa9795717744b80f7ea0cdf | |
parent | 1b788255775e9076b04c3c2a8818714ba96652e1 (diff) | |
download | llvm-5fc3e76ec4f323c22cddf7b9458137510507847a.zip llvm-5fc3e76ec4f323c22cddf7b9458137510507847a.tar.gz llvm-5fc3e76ec4f323c22cddf7b9458137510507847a.tar.bz2 |
[Github][CI] Make the new premerge system fail jobs on errors
This patch makes the new premerge system report failures when the build
errors out. We were previously not doing this to not notify people on
failures as we were testing out the infra.
This works towards making the new premerge system canonical and the
deprecation of the old system.
A launch announcement on Discourse will accompany this commit.
Reviewers: cmtice, tstellar, joker-eph, Keenuts, dschuff, lnihlen, gburgessiv
Reviewed By: tstellar, joker-eph, Keenuts
Pull Request: https://github.com/llvm/llvm-project/pull/139359
-rw-r--r-- | .github/workflows/premerge.yaml | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/.github/workflows/premerge.yaml b/.github/workflows/premerge.yaml index 74ac80b..3d29f22 100644 --- a/.github/workflows/premerge.yaml +++ b/.github/workflows/premerge.yaml @@ -42,9 +42,6 @@ jobs: # Mark the job as a success even if the step fails so that people do # not get notified while the new premerge pipeline is in an # experimental state. - # TODO(boomanaiden154): Remove this once the pipeline is stable and we - # are ready for people to start recieving notifications. - continue-on-error: true run: | git config --global --add safe.directory '*' @@ -109,9 +106,6 @@ jobs: # Mark the job as a success even if the step fails so that people do # not get notified while the new premerge pipeline is in an # experimental state. - # TODO(boomanaiden154): Remove this once the pipeline is stable and we - # are ready for people to start recieving notifications. - continue-on-error: true if: ${{ steps.vars.outputs.windows-projects != '' }} shell: cmd run: | |