aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCraig Topper <craig.topper@sifive.com>2022-08-17 09:40:49 -0700
committerCraig Topper <craig.topper@sifive.com>2022-08-17 09:50:08 -0700
commit550fab53e1dab6e5640c62a9a30a25a59ca1e735 (patch)
tree1f85d7e602b7ab7d41cc944db4328db1d5e18f20
parentab4cd154c6deffb0211ff4d2ac1f0932d8de0d74 (diff)
downloadllvm-550fab53e1dab6e5640c62a9a30a25a59ca1e735.zip
llvm-550fab53e1dab6e5640c62a9a30a25a59ca1e735.tar.gz
llvm-550fab53e1dab6e5640c62a9a30a25a59ca1e735.tar.bz2
[RISCV] Fold (sub C, (xor (setcc), 1)) -> (add (setcc), C-1).
Extracted from D131729 where we handled C==0. It's now generalized to more constants. Reviewed By: reames Differential Revision: https://reviews.llvm.org/D132000
-rw-r--r--llvm/lib/Target/RISCV/RISCVISelLowering.cpp5
-rw-r--r--llvm/test/CodeGen/RISCV/double-select-fcmp.ll7
-rw-r--r--llvm/test/CodeGen/RISCV/float-select-fcmp.ll7
-rw-r--r--llvm/test/CodeGen/RISCV/half-select-fcmp.ll7
4 files changed, 11 insertions, 15 deletions
diff --git a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
index a9a700e..5d0fb6d 100644
--- a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
+++ b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
@@ -8306,6 +8306,11 @@ static SDValue combineSubOfBoolean(SDNode *N, SelectionDAG &DAG) {
CCVal = ISD::getSetCCInverse(CCVal, SetCCOpVT);
NewLHS =
DAG.getSetCC(SDLoc(N1), VT, N1.getOperand(0), N1.getOperand(1), CCVal);
+ } else if (N1.getOpcode() == ISD::XOR && isOneConstant(N1.getOperand(1)) &&
+ N1.getOperand(0).getOpcode() == ISD::SETCC) {
+ // (sub C, (xor (setcc), 1)) -> (add (setcc), C-1).
+ // Since setcc returns a bool the xor is equivalent to 1-setcc.
+ NewLHS = N1.getOperand(0);
} else
return SDValue();
diff --git a/llvm/test/CodeGen/RISCV/double-select-fcmp.ll b/llvm/test/CodeGen/RISCV/double-select-fcmp.ll
index 43c70c6..b3cb0e8 100644
--- a/llvm/test/CodeGen/RISCV/double-select-fcmp.ll
+++ b/llvm/test/CodeGen/RISCV/double-select-fcmp.ll
@@ -258,8 +258,7 @@ define signext i32 @select_fcmp_uge_negone_zero(double %a, double %b) nounwind {
; CHECK-LABEL: select_fcmp_uge_negone_zero:
; CHECK: # %bb.0:
; CHECK-NEXT: fle.d a0, fa0, fa1
-; CHECK-NEXT: xori a0, a0, 1
-; CHECK-NEXT: neg a0, a0
+; CHECK-NEXT: addi a0, a0, -1
; CHECK-NEXT: ret
%1 = fcmp ugt double %a, %b
%2 = select i1 %1, i32 -1, i32 0
@@ -270,9 +269,7 @@ define signext i32 @select_fcmp_uge_1_2(double %a, double %b) nounwind {
; CHECK-LABEL: select_fcmp_uge_1_2:
; CHECK: # %bb.0:
; CHECK-NEXT: fle.d a0, fa0, fa1
-; CHECK-NEXT: xori a0, a0, 1
-; CHECK-NEXT: li a1, 2
-; CHECK-NEXT: sub a0, a1, a0
+; CHECK-NEXT: addi a0, a0, 1
; CHECK-NEXT: ret
%1 = fcmp ugt double %a, %b
%2 = select i1 %1, i32 1, i32 2
diff --git a/llvm/test/CodeGen/RISCV/float-select-fcmp.ll b/llvm/test/CodeGen/RISCV/float-select-fcmp.ll
index d320f3e..c6e8836 100644
--- a/llvm/test/CodeGen/RISCV/float-select-fcmp.ll
+++ b/llvm/test/CodeGen/RISCV/float-select-fcmp.ll
@@ -258,8 +258,7 @@ define signext i32 @select_fcmp_uge_negone_zero(float %a, float %b) nounwind {
; CHECK-LABEL: select_fcmp_uge_negone_zero:
; CHECK: # %bb.0:
; CHECK-NEXT: fle.s a0, fa0, fa1
-; CHECK-NEXT: xori a0, a0, 1
-; CHECK-NEXT: neg a0, a0
+; CHECK-NEXT: addi a0, a0, -1
; CHECK-NEXT: ret
%1 = fcmp ugt float %a, %b
%2 = select i1 %1, i32 -1, i32 0
@@ -270,9 +269,7 @@ define signext i32 @select_fcmp_uge_1_2(float %a, float %b) nounwind {
; CHECK-LABEL: select_fcmp_uge_1_2:
; CHECK: # %bb.0:
; CHECK-NEXT: fle.s a0, fa0, fa1
-; CHECK-NEXT: xori a0, a0, 1
-; CHECK-NEXT: li a1, 2
-; CHECK-NEXT: sub a0, a1, a0
+; CHECK-NEXT: addi a0, a0, 1
; CHECK-NEXT: ret
%1 = fcmp ugt float %a, %b
%2 = select i1 %1, i32 1, i32 2
diff --git a/llvm/test/CodeGen/RISCV/half-select-fcmp.ll b/llvm/test/CodeGen/RISCV/half-select-fcmp.ll
index 92f2fdc..7c0ee568 100644
--- a/llvm/test/CodeGen/RISCV/half-select-fcmp.ll
+++ b/llvm/test/CodeGen/RISCV/half-select-fcmp.ll
@@ -258,8 +258,7 @@ define signext i32 @select_fcmp_uge_negone_zero(half %a, half %b) nounwind {
; CHECK-LABEL: select_fcmp_uge_negone_zero:
; CHECK: # %bb.0:
; CHECK-NEXT: fle.h a0, fa0, fa1
-; CHECK-NEXT: xori a0, a0, 1
-; CHECK-NEXT: neg a0, a0
+; CHECK-NEXT: addi a0, a0, -1
; CHECK-NEXT: ret
%1 = fcmp ugt half %a, %b
%2 = select i1 %1, i32 -1, i32 0
@@ -270,9 +269,7 @@ define signext i32 @select_fcmp_uge_1_2(half %a, half %b) nounwind {
; CHECK-LABEL: select_fcmp_uge_1_2:
; CHECK: # %bb.0:
; CHECK-NEXT: fle.h a0, fa0, fa1
-; CHECK-NEXT: xori a0, a0, 1
-; CHECK-NEXT: li a1, 2
-; CHECK-NEXT: sub a0, a1, a0
+; CHECK-NEXT: addi a0, a0, 1
; CHECK-NEXT: ret
%1 = fcmp ugt half %a, %b
%2 = select i1 %1, i32 1, i32 2