aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorwalter erquinigo <walter@modular.com>2024-07-05 11:50:02 -0400
committerwalter erquinigo <walter@modular.com>2024-07-05 13:12:13 -0400
commit3bfc5167d9e49b9a53e364e8d8853fce543cca0f (patch)
tree3ccfd2dbcaf1952806a1f4d82ac250c433e3ba61
parent6c1c97c5b6744397063d9976bead154be38b8388 (diff)
downloadllvm-3bfc5167d9e49b9a53e364e8d8853fce543cca0f.zip
llvm-3bfc5167d9e49b9a53e364e8d8853fce543cca0f.tar.gz
llvm-3bfc5167d9e49b9a53e364e8d8853fce543cca0f.tar.bz2
[lldb-dap][NFC] Minor rename
As a minor follow up for https://github.com/llvm/llvm-project/pull/97675, I'm renaming `SupportsExceptionBreakpoints` to `SupportsExceptionBreakpointsOnThrow` and adding a `SupportsExceptionBreakpointsOnCatch` to have a bit of more granularity.
-rw-r--r--lldb/include/lldb/Target/Language.h10
-rw-r--r--lldb/source/Commands/CommandObjectBreakpoint.cpp3
-rw-r--r--lldb/source/Plugins/Language/ObjC/ObjCLanguage.h2
3 files changed, 10 insertions, 5 deletions
diff --git a/lldb/include/lldb/Target/Language.h b/lldb/include/lldb/Target/Language.h
index 2d6e5a4..83bf763 100644
--- a/lldb/include/lldb/Target/Language.h
+++ b/lldb/include/lldb/Target/Language.h
@@ -363,9 +363,13 @@ public:
return false;
}
- /// Returns true if this Language supports exception breakpoints via a
- /// corresponding LanguageRuntime plugin.
- virtual bool SupportsExceptionBreakpoints() const { return false; }
+ /// Returns true if this Language supports exception breakpoints on throw via
+ /// a corresponding LanguageRuntime plugin.
+ virtual bool SupportsExceptionBreakpointsOnThrow() const { return false; }
+
+ /// Returns true if this Language supports exception breakpoints on catch via
+ /// a corresponding LanguageRuntime plugin.
+ virtual bool SupportsExceptionBreakpointsOnCatch() const { return false; }
protected:
// Classes that inherit from Language can see and modify these
diff --git a/lldb/source/Commands/CommandObjectBreakpoint.cpp b/lldb/source/Commands/CommandObjectBreakpoint.cpp
index a5fe927..773f8ed 100644
--- a/lldb/source/Commands/CommandObjectBreakpoint.cpp
+++ b/lldb/source/Commands/CommandObjectBreakpoint.cpp
@@ -317,7 +317,8 @@ public:
break;
default:
if (Language *languagePlugin = Language::FindPlugin(language)) {
- if (languagePlugin->SupportsExceptionBreakpoints()) {
+ if (languagePlugin->SupportsExceptionBreakpointsOnThrow() ||
+ languagePlugin->SupportsExceptionBreakpointsOnCatch()) {
m_exception_language = language;
break;
}
diff --git a/lldb/source/Plugins/Language/ObjC/ObjCLanguage.h b/lldb/source/Plugins/Language/ObjC/ObjCLanguage.h
index a61d0f1..d9c0cd3c 100644
--- a/lldb/source/Plugins/Language/ObjC/ObjCLanguage.h
+++ b/lldb/source/Plugins/Language/ObjC/ObjCLanguage.h
@@ -194,7 +194,7 @@ public:
llvm::StringRef GetInstanceVariableName() override { return "self"; }
- bool SupportsExceptionBreakpoints() const override { return true; }
+ bool SupportsExceptionBreakpointsOnThrow() const override { return true; }
// PluginInterface protocol
llvm::StringRef GetPluginName() override { return GetPluginNameStatic(); }