aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorserge-sans-paille <sguelton@mozilla.com>2023-11-13 08:59:29 +0100
committerserge-sans-paille <sguelton@mozilla.com>2023-11-15 15:01:36 +0100
commit33b51588c5d51995909f1f0be0b47b1708dac4fa (patch)
tree6837bef3c9bbea3e6cee3aebc2041316c031e4fb
parent2060bfcdc7eb704647c64bf925cdceb94c1f535f (diff)
downloadllvm-33b51588c5d51995909f1f0be0b47b1708dac4fa.zip
llvm-33b51588c5d51995909f1f0be0b47b1708dac4fa.tar.gz
llvm-33b51588c5d51995909f1f0be0b47b1708dac4fa.tar.bz2
Replace usage of StringRef::find_last_of with a string literal of size one by the equivalent char literal
-rw-r--r--clang/lib/Driver/ToolChains/ZOS.cpp2
-rw-r--r--llvm/lib/Target/AMDGPU/AMDGPUPrintfRuntimeBinding.cpp2
-rw-r--r--llvm/lib/Target/SPIRV/SPIRVBuiltins.cpp2
-rw-r--r--mlir/lib/Tools/lsp-server-support/SourceMgrUtils.cpp2
4 files changed, 4 insertions, 4 deletions
diff --git a/clang/lib/Driver/ToolChains/ZOS.cpp b/clang/lib/Driver/ToolChains/ZOS.cpp
index a7d6f03..96dbf60 100644
--- a/clang/lib/Driver/ToolChains/ZOS.cpp
+++ b/clang/lib/Driver/ToolChains/ZOS.cpp
@@ -143,7 +143,7 @@ void zos::Linker::ConstructJob(Compilation &C, const JobAction &JA,
StringRef OutputName = Output.getFilename();
// Strip away the last file suffix in presence from output name and add
// a new .x suffix.
- size_t Suffix = OutputName.find_last_of(".");
+ size_t Suffix = OutputName.find_last_of('.');
const char *SideDeckName =
Args.MakeArgString(OutputName.substr(0, Suffix) + ".x");
CmdArgs.push_back("-x");
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUPrintfRuntimeBinding.cpp b/llvm/lib/Target/AMDGPU/AMDGPUPrintfRuntimeBinding.cpp
index d03820f..7b5dc37 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUPrintfRuntimeBinding.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUPrintfRuntimeBinding.cpp
@@ -102,7 +102,7 @@ void AMDGPUPrintfRuntimeBindingImpl::getConversionSpecifiers(
bool ArgDump = false;
StringRef CurFmt = Fmt.substr(PrevFmtSpecifierIdx,
CurFmtSpecifierIdx - PrevFmtSpecifierIdx);
- size_t pTag = CurFmt.find_last_of("%");
+ size_t pTag = CurFmt.find_last_of('%');
if (pTag != StringRef::npos) {
ArgDump = true;
while (pTag && CurFmt[--pTag] == '%') {
diff --git a/llvm/lib/Target/SPIRV/SPIRVBuiltins.cpp b/llvm/lib/Target/SPIRV/SPIRVBuiltins.cpp
index d635487..ae9e801 100644
--- a/llvm/lib/Target/SPIRV/SPIRVBuiltins.cpp
+++ b/llvm/lib/Target/SPIRV/SPIRVBuiltins.cpp
@@ -163,7 +163,7 @@ lookupBuiltin(StringRef DemangledCall,
// the information after angle brackets and return type removed.
if (BuiltinName.find('<') && BuiltinName.back() == '>') {
BuiltinName = BuiltinName.substr(0, BuiltinName.find('<'));
- BuiltinName = BuiltinName.substr(BuiltinName.find_last_of(" ") + 1);
+ BuiltinName = BuiltinName.substr(BuiltinName.find_last_of(' ') + 1);
}
// Check if the extracted name begins with "__spirv_ImageSampleExplicitLod"
diff --git a/mlir/lib/Tools/lsp-server-support/SourceMgrUtils.cpp b/mlir/lib/Tools/lsp-server-support/SourceMgrUtils.cpp
index fe66813..b6f4f3c 100644
--- a/mlir/lib/Tools/lsp-server-support/SourceMgrUtils.cpp
+++ b/mlir/lib/Tools/lsp-server-support/SourceMgrUtils.cpp
@@ -83,7 +83,7 @@ lsp::extractSourceDocComment(llvm::SourceMgr &sourceMgr, SMLoc loc) {
// Pop the last line from the buffer string.
auto popLastLine = [&]() -> std::optional<StringRef> {
- size_t newlineOffset = buffer.find_last_of("\n");
+ size_t newlineOffset = buffer.find_last_of('\n');
if (newlineOffset == StringRef::npos)
return std::nullopt;
StringRef lastLine = buffer.drop_front(newlineOffset).trim();