diff options
| author | Raphael Isemann <teemperor@gmail.com> | 2021-06-17 09:52:08 +0200 |
|---|---|---|
| committer | Raphael Isemann <teemperor@gmail.com> | 2021-06-17 09:52:09 +0200 |
| commit | 25fa67868b36c99d2704bd291b3b495737f16f0e (patch) | |
| tree | f1857e07363d24c7149d34fadb3ace8c069770ad | |
| parent | 4c7f820b2b206bb7b4e32e575a78316701471203 (diff) | |
| download | llvm-25fa67868b36c99d2704bd291b3b495737f16f0e.zip llvm-25fa67868b36c99d2704bd291b3b495737f16f0e.tar.gz llvm-25fa67868b36c99d2704bd291b3b495737f16f0e.tar.bz2 | |
[lldb] Skip variant/optional libc++ tests for Clang 5/6
Clang 5 and Clang 6 can no longer parse newer versions of libc++. As we can't
specify the specific libc++ version in the decorator, let's only allow Clang
versions that can parse all currently available libc++ versions.
2 files changed, 6 insertions, 4 deletions
diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/optional/TestDataFormatterLibcxxOptional.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/optional/TestDataFormatterLibcxxOptional.py index f013d02..27c8d7f 100644 --- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/optional/TestDataFormatterLibcxxOptional.py +++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/optional/TestDataFormatterLibcxxOptional.py @@ -15,8 +15,9 @@ class LibcxxOptionalDataFormatterTestCase(TestBase): mydir = TestBase.compute_mydir(__file__) @add_test_categories(["libc++"]) - ## We are skipping clang version less that 5.0 since this test requires -std=c++17 - @skipIf(oslist=no_match(["macosx"]), compiler="clang", compiler_version=['<', '5.0']) + ## Clang 7.0 is the oldest Clang that can reliably parse newer libc++ versions + ## with -std=c++17. + @skipIf(oslist=no_match(["macosx"]), compiler="clang", compiler_version=['<', '7.0']) ## We are skipping gcc version less that 5.1 since this test requires -std=c++17 @skipIf(compiler="gcc", compiler_version=['<', '5.1']) diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/variant/TestDataFormatterLibcxxVariant.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/variant/TestDataFormatterLibcxxVariant.py index cea4fd6..181dca7 100644 --- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/variant/TestDataFormatterLibcxxVariant.py +++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/variant/TestDataFormatterLibcxxVariant.py @@ -14,8 +14,9 @@ class LibcxxVariantDataFormatterTestCase(TestBase): mydir = TestBase.compute_mydir(__file__) @add_test_categories(["libc++"]) - ## We are skipping clang version less that 5.0 since this test requires -std=c++17 - @skipIf(oslist=no_match(["macosx"]), compiler="clang", compiler_version=['<', '5.0']) + ## Clang 7.0 is the oldest Clang that can reliably parse newer libc++ versions + ## with -std=c++17. + @skipIf(oslist=no_match(["macosx"]), compiler="clang", compiler_version=['<', '7.0']) ## We are skipping gcc version less that 5.1 since this test requires -std=c++17 @skipIf(compiler="gcc", compiler_version=['<', '5.1']) ## std::get is unavailable for std::variant before macOS 10.14 |