aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKazu Hirata <kazu@google.com>2020-05-11 14:04:10 -0700
committerKazu Hirata <kazu@google.com>2020-05-11 17:43:31 -0700
commit0205fabe5dfbc77a4a42b9961bcbbd6eccace93e (patch)
treebb638cbae8092ca82ab1406c87dcf0ef4454e233
parentc9c930ae67c38b93451aa979de723723aec0067d (diff)
downloadllvm-0205fabe5dfbc77a4a42b9961bcbbd6eccace93e.zip
llvm-0205fabe5dfbc77a4a42b9961bcbbd6eccace93e.tar.gz
llvm-0205fabe5dfbc77a4a42b9961bcbbd6eccace93e.tar.bz2
[Inlining] Make shouldBeDeferred static (NFC)
Summary: This patch makes shouldBeDeferred static because it is called only from shouldInline in the same .cpp file. Reviewers: davidxl, mtrofin Reviewed By: mtrofin Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D79750
-rw-r--r--llvm/include/llvm/Analysis/InlineAdvisor.h8
-rw-r--r--llvm/lib/Analysis/InlineAdvisor.cpp6
2 files changed, 3 insertions, 11 deletions
diff --git a/llvm/include/llvm/Analysis/InlineAdvisor.h b/llvm/include/llvm/Analysis/InlineAdvisor.h
index 8fc2ca2..3dab782 100644
--- a/llvm/include/llvm/Analysis/InlineAdvisor.h
+++ b/llvm/include/llvm/Analysis/InlineAdvisor.h
@@ -25,14 +25,6 @@ class OptimizationRemarkEmitter;
// Default (manual policy) decision making helper APIs. Shared with the legacy
// pass manager inliner.
-/// Return true if inlining of CB can block the caller from being
-/// inlined which is proved to be more beneficial. \p IC is the
-/// estimated inline cost associated with callsite \p CB.
-/// \p TotalSecondaryCost will be set to the estimated cost of inlining the
-/// caller if \p CB is suppressed for inlining.
-bool shouldBeDeferred(Function *Caller, InlineCost IC, int &TotalSecondaryCost,
- function_ref<InlineCost(CallBase &CB)> GetInlineCost);
-
/// Return the cost only if the inliner should attempt to inline at the given
/// CallSite. If we return the cost, we will emit an optimisation remark later
/// using that cost, so we won't do so from this function. Return None if
diff --git a/llvm/lib/Analysis/InlineAdvisor.cpp b/llvm/lib/Analysis/InlineAdvisor.cpp
index eae0d24..e9d4f7e 100644
--- a/llvm/lib/Analysis/InlineAdvisor.cpp
+++ b/llvm/lib/Analysis/InlineAdvisor.cpp
@@ -51,9 +51,9 @@ static cl::opt<int>
/// estimated inline cost associated with callsite \p CB.
/// \p TotalSecondaryCost will be set to the estimated cost of inlining the
/// caller if \p CB is suppressed for inlining.
-bool llvm::shouldBeDeferred(
- Function *Caller, InlineCost IC, int &TotalSecondaryCost,
- function_ref<InlineCost(CallBase &CB)> GetInlineCost) {
+static bool
+shouldBeDeferred(Function *Caller, InlineCost IC, int &TotalSecondaryCost,
+ function_ref<InlineCost(CallBase &CB)> GetInlineCost) {
// For now we only handle local or inline functions.
if (!Caller->hasLocalLinkage() && !Caller->hasLinkOnceODRLinkage())
return false;