diff options
| author | Florian Weimer <fweimer@redhat.com> | 2024-04-13 16:17:38 +0200 |
|---|---|---|
| committer | Florian Weimer <fweimer@redhat.com> | 2024-04-13 17:42:13 +0200 |
| commit | aea52e3d2b71e89f2ba4fd4d8f1f8d3036d83c1d (patch) | |
| tree | a4d1718dd22e6fc0b757e4455fa4fe82bd2ccd66 /sysdeps/x86_64 | |
| parent | cf11e74b0d81d389bcad5cdbba020ba475f0ac4b (diff) | |
| download | glibc-aea52e3d2b71e89f2ba4fd4d8f1f8d3036d83c1d.zip glibc-aea52e3d2b71e89f2ba4fd4d8f1f8d3036d83c1d.tar.gz glibc-aea52e3d2b71e89f2ba4fd4d8f1f8d3036d83c1d.tar.bz2 | |
Revert "x86_64: Suppress false positive valgrind error"
This reverts commit a1735e0aa858f0c8b15e5ee9975bff4279423680.
The test failure is a real valgrind bug that needs to be fixed before
valgrind is usable with a glibc that has been built with
CC="gcc -march=x86-64-v3". The proposed valgrind patch teaches
valgrind to replace ld.so strcmp with an unoptimized scalar
implementation, thus avoiding any AVX2-related problems.
Valgrind bug: <https://bugs.kde.org/show_bug.cgi?id=485487>
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
Diffstat (limited to 'sysdeps/x86_64')
| -rw-r--r-- | sysdeps/x86_64/Makefile | 7 | ||||
| -rw-r--r-- | sysdeps/x86_64/tst-valgrind-smoke.supp | 17 |
2 files changed, 0 insertions, 24 deletions
diff --git a/sysdeps/x86_64/Makefile b/sysdeps/x86_64/Makefile index 39048b1..ce949db 100644 --- a/sysdeps/x86_64/Makefile +++ b/sysdeps/x86_64/Makefile @@ -211,14 +211,7 @@ tst-plt-rewrite2-ENV = GLIBC_TUNABLES=glibc.cpu.plt_rewrite=2 $(objpfx)tst-plt-rewrite2: $(objpfx)tst-plt-rewritemod2.so endif -# Check if ISA level is 3 or above. -ifneq (,$(filter $(have-x86-isa-level),$(x86-isa-level-3-or-above))) -valgrind-suppressions-tst-valgrind-smoke = \ - --suppressions=$(..)sysdeps/x86_64/tst-valgrind-smoke.supp -endif - test-internal-extras += tst-gnu2-tls2mod1 - endif # $(subdir) == elf ifeq ($(subdir),csu) diff --git a/sysdeps/x86_64/tst-valgrind-smoke.supp b/sysdeps/x86_64/tst-valgrind-smoke.supp deleted file mode 100644 index 533c2de..0000000 --- a/sysdeps/x86_64/tst-valgrind-smoke.supp +++ /dev/null @@ -1,17 +0,0 @@ -{ - False positive at strcmp-avx2.S:462 - Memcheck:Cond - fun:strcmp - fun:_dl_name_match_p - fun:_dl_map_object - fun:map_doit - fun:_dl_catch_exception - fun:_dl_catch_error - fun:do_preload - fun:handle_preload_list - fun:dl_main - fun:_dl_sysdep_start - fun:_dl_start_final - fun:_dl_start - obj:*/elf/ld.so -} |