diff options
| author | H.J. Lu <hjl.tools@gmail.com> | 2017-06-15 08:58:56 -0700 |
|---|---|---|
| committer | H.J. Lu <hjl.tools@gmail.com> | 2017-06-15 08:59:05 -0700 |
| commit | 70fe2eb79417166c39a36699f591138bfe5c5307 (patch) | |
| tree | 0f177c3b8e9c1c5cce5e2d606e4c058f3e2c0449 /sysdeps/x86_64/strcspn.S | |
| parent | 9f4254b8bd1b948c3a90e48a126236bf3e5e70a0 (diff) | |
| download | glibc-70fe2eb79417166c39a36699f591138bfe5c5307.zip glibc-70fe2eb79417166c39a36699f591138bfe5c5307.tar.gz glibc-70fe2eb79417166c39a36699f591138bfe5c5307.tar.bz2 | |
x86-64: Implement strcspn/strpbrk/strspn IFUNC selectors in C
Implement strcspn/strpbrk/strspn IFUNC selectors in C
All internal calls within libc.so can use IFUNC on x86-64 since unlike
x86, x86-64 supports PC-relative addressing to access the GOT entry so
that it can call via PLT without using an extra register. For libc.a,
we can't use IFUNC for functions which are called before IFUNC has been
initialized. Use IFUNC internally reduces the icache footprint since
libc.so and other codes in the process use the same implementations.
This patch uses IFUNC for strcspn/strpbrk/strspn functions within libc.
* sysdeps/x86_64/multiarch/Makefile (sysdep_routines): Add
strcspn-sse2, strpbrk-sse2 and strspn-sse2.
* sysdeps/x86_64/strcspn.S (STRPBRK_P): Removed.
Check USE_AS_STRPBRK instead of STRPBRK_P.
* sysdeps/x86_64/strpbrk.S (USE_AS_STRPBRK): New.
* sysdeps/x86_64/multiarch/ifunc-sse4_2.h: New file.
* sysdeps/x86_64/multiarch/strcspn-sse2.S: Likewise.
* sysdeps/x86_64/multiarch/strcspn.c: Likewise.
* sysdeps/x86_64/multiarch/strpbrk-sse2.S: Likewise.
* sysdeps/x86_64/multiarch/strpbrk.c: Likewise.
* sysdeps/x86_64/multiarch/strspn-sse2.S: Likewise.
* sysdeps/x86_64/multiarch/strspn.c: Likewise.
* sysdeps/x86_64/multiarch/strcspn.S: Removed.
* sysdeps/x86_64/multiarch/strpbrk.S: Likewise.
* sysdeps/x86_64/multiarch/strspn.S: Likewise.
* sysdeps/x86_64/multiarch/strpbrk-c.c: Remove "#ifdef SHARED"
and "#endif".
Diffstat (limited to 'sysdeps/x86_64/strcspn.S')
| -rw-r--r-- | sysdeps/x86_64/strcspn.S | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/sysdeps/x86_64/strcspn.S b/sysdeps/x86_64/strcspn.S index a1d1f7d..e450a1e 100644 --- a/sysdeps/x86_64/strcspn.S +++ b/sysdeps/x86_64/strcspn.S @@ -24,9 +24,6 @@ #include <sysdep.h> #include "asm-syntax.h" -/* BEWARE: `#ifdef strcspn' means that strcspn is redefined as `strpbrk' */ -#define STRPBRK_P (defined strcspn) - .text ENTRY (strcspn) @@ -111,7 +108,7 @@ L(5): incq %rax L(4): addq $256, %rsp /* remove skipset */ cfi_adjust_cfa_offset(-256) -#if STRPBRK_P +#ifdef USE_AS_STRPBRK xorl %edx,%edx orb %cl, %cl /* was last character NUL? */ cmovzq %rdx, %rax /* Yes: return NULL */ |