diff options
author | Joseph Myers <joseph@codesourcery.com> | 2018-09-03 21:09:04 +0000 |
---|---|---|
committer | Joseph Myers <joseph@codesourcery.com> | 2018-09-03 21:09:04 +0000 |
commit | 70e2ba332f887760f56700baf7adcf441ff50ba9 (patch) | |
tree | 8daf453f0d374fcb3e125efe644cf2a526e91d25 /sysdeps/riscv/rvf | |
parent | a6e8926f8d49a213a9abb1a61f6af964f612ab7f (diff) | |
download | glibc-70e2ba332f887760f56700baf7adcf441ff50ba9.zip glibc-70e2ba332f887760f56700baf7adcf441ff50ba9.tar.gz glibc-70e2ba332f887760f56700baf7adcf441ff50ba9.tar.bz2 |
Do not include fenv_private.h in math_private.h.
Continuing the clean-up related to the catch-all math_private.h
header, this patch stops math_private.h from including fenv_private.h.
Instead, fenv_private.h is included directly from those users of
math_private.h that also used interfaces from fenv_private.h. No
attempt is made to remove unused includes of math_private.h, but that
is a natural followup.
(However, since math_private.h sometimes defines optimized versions of
math.h interfaces or __* variants thereof, as well as defining its own
interfaces, I think it might make sense to get all those optimized
versions included from include/math.h, not requiring a separate header
at all, before eliminating unused math_private.h includes - that
avoids a file quietly becoming less-optimized if someone adds a call
to one of those interfaces without restoring a math_private.h include
to that file.)
There is still a pitfall that if code uses plain fe* and __fe*
interfaces, but only includes fenv.h and not fenv_private.h or (before
this patch) math_private.h, it will compile on platforms with
exceptions and rounding modes but not get the optimized versions (and
possibly not compile) on platforms without exception and rounding mode
support, so making it easy to break the build for such platforms
accidentally.
I think it would be most natural to move the inlines / macros for fe*
and __fe* in the case of no exceptions and rounding modes into
include/fenv.h, so that all code including fenv.h with _ISOMAC not
defined automatically gets them. Then fenv_private.h would be purely
the header for the libc_fe*, SET_RESTORE_ROUND etc. internal
interfaces and the risk of breaking the build on other platforms than
the one you tested on because of a missing fenv_private.h include
would be much reduced (and there would be some unused fenv_private.h
includes to remove along with unused math_private.h includes).
Tested for x86_64 and x86, and tested with build-many-glibcs.py that
installed stripped shared libraries are unchanged by this patch.
* sysdeps/generic/math_private.h: Do not include <fenv_private.h>.
* math/fromfp.h: Include <fenv_private.h>.
* math/math-narrow.h: Likewise.
* math/s_cexp_template.c: Likewise.
* math/s_csin_template.c: Likewise.
* math/s_csinh_template.c: Likewise.
* math/s_ctan_template.c: Likewise.
* math/s_ctanh_template.c: Likewise.
* math/s_iseqsig_template.c: Likewise.
* math/w_acos_compat.c: Likewise.
* math/w_acosf_compat.c: Likewise.
* math/w_acosl_compat.c: Likewise.
* math/w_asin_compat.c: Likewise.
* math/w_asinf_compat.c: Likewise.
* math/w_asinl_compat.c: Likewise.
* math/w_ilogb_template.c: Likewise.
* math/w_j0_compat.c: Likewise.
* math/w_j0f_compat.c: Likewise.
* math/w_j0l_compat.c: Likewise.
* math/w_j1_compat.c: Likewise.
* math/w_j1f_compat.c: Likewise.
* math/w_j1l_compat.c: Likewise.
* math/w_jn_compat.c: Likewise.
* math/w_jnf_compat.c: Likewise.
* math/w_llogb_template.c: Likewise.
* math/w_log10_compat.c: Likewise.
* math/w_log10f_compat.c: Likewise.
* math/w_log10l_compat.c: Likewise.
* math/w_log2_compat.c: Likewise.
* math/w_log2f_compat.c: Likewise.
* math/w_log2l_compat.c: Likewise.
* math/w_log_compat.c: Likewise.
* math/w_logf_compat.c: Likewise.
* math/w_logl_compat.c: Likewise.
* sysdeps/aarch64/fpu/feholdexcpt.c: Likewise.
* sysdeps/aarch64/fpu/fesetround.c: Likewise.
* sysdeps/aarch64/fpu/fgetexcptflg.c: Likewise.
* sysdeps/aarch64/fpu/ftestexcept.c: Likewise.
* sysdeps/ieee754/dbl-64/e_atan2.c: Likewise.
* sysdeps/ieee754/dbl-64/e_exp.c: Likewise.
* sysdeps/ieee754/dbl-64/e_exp2.c: Likewise.
* sysdeps/ieee754/dbl-64/e_gamma_r.c: Likewise.
* sysdeps/ieee754/dbl-64/e_jn.c: Likewise.
* sysdeps/ieee754/dbl-64/e_pow.c: Likewise.
* sysdeps/ieee754/dbl-64/e_remainder.c: Likewise.
* sysdeps/ieee754/dbl-64/e_sqrt.c: Likewise.
* sysdeps/ieee754/dbl-64/gamma_product.c: Likewise.
* sysdeps/ieee754/dbl-64/lgamma_neg.c: Likewise.
* sysdeps/ieee754/dbl-64/s_atan.c: Likewise.
* sysdeps/ieee754/dbl-64/s_fma.c: Likewise.
* sysdeps/ieee754/dbl-64/s_fmaf.c: Likewise.
* sysdeps/ieee754/dbl-64/s_llrint.c: Likewise.
* sysdeps/ieee754/dbl-64/s_llround.c: Likewise.
* sysdeps/ieee754/dbl-64/s_lrint.c: Likewise.
* sysdeps/ieee754/dbl-64/s_lround.c: Likewise.
* sysdeps/ieee754/dbl-64/s_nearbyint.c: Likewise.
* sysdeps/ieee754/dbl-64/s_sin.c: Likewise.
* sysdeps/ieee754/dbl-64/s_sincos.c: Likewise.
* sysdeps/ieee754/dbl-64/s_tan.c: Likewise.
* sysdeps/ieee754/dbl-64/wordsize-64/s_lround.c: Likewise.
* sysdeps/ieee754/dbl-64/wordsize-64/s_nearbyint.c: Likewise.
* sysdeps/ieee754/dbl-64/x2y2m1.c: Likewise.
* sysdeps/ieee754/float128/float128_private.h: Likewise.
* sysdeps/ieee754/flt-32/e_gammaf_r.c: Likewise.
* sysdeps/ieee754/flt-32/e_j1f.c: Likewise.
* sysdeps/ieee754/flt-32/e_jnf.c: Likewise.
* sysdeps/ieee754/flt-32/lgamma_negf.c: Likewise.
* sysdeps/ieee754/flt-32/s_llrintf.c: Likewise.
* sysdeps/ieee754/flt-32/s_llroundf.c: Likewise.
* sysdeps/ieee754/flt-32/s_lrintf.c: Likewise.
* sysdeps/ieee754/flt-32/s_lroundf.c: Likewise.
* sysdeps/ieee754/flt-32/s_nearbyintf.c: Likewise.
* sysdeps/ieee754/k_standardl.c: Likewise.
* sysdeps/ieee754/ldbl-128/e_expl.c: Likewise.
* sysdeps/ieee754/ldbl-128/e_gammal_r.c: Likewise.
* sysdeps/ieee754/ldbl-128/e_j1l.c: Likewise.
* sysdeps/ieee754/ldbl-128/e_jnl.c: Likewise.
* sysdeps/ieee754/ldbl-128/gamma_productl.c: Likewise.
* sysdeps/ieee754/ldbl-128/lgamma_negl.c: Likewise.
* sysdeps/ieee754/ldbl-128/s_fmal.c: Likewise.
* sysdeps/ieee754/ldbl-128/s_llrintl.c: Likewise.
* sysdeps/ieee754/ldbl-128/s_llroundl.c: Likewise.
* sysdeps/ieee754/ldbl-128/s_lrintl.c: Likewise.
* sysdeps/ieee754/ldbl-128/s_lroundl.c: Likewise.
* sysdeps/ieee754/ldbl-128/s_nearbyintl.c: Likewise.
* sysdeps/ieee754/ldbl-128/x2y2m1l.c: Likewise.
* sysdeps/ieee754/ldbl-128ibm/e_expl.c: Likewise.
* sysdeps/ieee754/ldbl-128ibm/e_gammal_r.c: Likewise.
* sysdeps/ieee754/ldbl-128ibm/e_j1l.c: Likewise.
* sysdeps/ieee754/ldbl-128ibm/e_jnl.c: Likewise.
* sysdeps/ieee754/ldbl-128ibm/lgamma_negl.c: Likewise.
* sysdeps/ieee754/ldbl-128ibm/s_fmal.c: Likewise.
* sysdeps/ieee754/ldbl-128ibm/s_llrintl.c: Likewise.
* sysdeps/ieee754/ldbl-128ibm/s_llroundl.c: Likewise.
* sysdeps/ieee754/ldbl-128ibm/s_lrintl.c: Likewise.
* sysdeps/ieee754/ldbl-128ibm/s_lroundl.c: Likewise.
* sysdeps/ieee754/ldbl-128ibm/s_rintl.c: Likewise.
* sysdeps/ieee754/ldbl-128ibm/x2y2m1l.c: Likewise.
* sysdeps/ieee754/ldbl-96/e_gammal_r.c: Likewise.
* sysdeps/ieee754/ldbl-96/e_jnl.c: Likewise.
* sysdeps/ieee754/ldbl-96/gamma_productl.c: Likewise.
* sysdeps/ieee754/ldbl-96/lgamma_negl.c: Likewise.
* sysdeps/ieee754/ldbl-96/s_fma.c: Likewise.
* sysdeps/ieee754/ldbl-96/s_fmal.c: Likewise.
* sysdeps/ieee754/ldbl-96/s_llrintl.c: Likewise.
* sysdeps/ieee754/ldbl-96/s_llroundl.c: Likewise.
* sysdeps/ieee754/ldbl-96/s_lrintl.c: Likewise.
* sysdeps/ieee754/ldbl-96/s_lroundl.c: Likewise.
* sysdeps/ieee754/ldbl-96/x2y2m1l.c: Likewise.
* sysdeps/powerpc/fpu/e_sqrt.c: Likewise.
* sysdeps/powerpc/fpu/e_sqrtf.c: Likewise.
* sysdeps/riscv/rv64/rvd/s_ceil.c: Likewise.
* sysdeps/riscv/rv64/rvd/s_floor.c: Likewise.
* sysdeps/riscv/rv64/rvd/s_nearbyint.c: Likewise.
* sysdeps/riscv/rv64/rvd/s_round.c: Likewise.
* sysdeps/riscv/rv64/rvd/s_roundeven.c: Likewise.
* sysdeps/riscv/rv64/rvd/s_trunc.c: Likewise.
* sysdeps/riscv/rvd/s_finite.c: Likewise.
* sysdeps/riscv/rvd/s_fmax.c: Likewise.
* sysdeps/riscv/rvd/s_fmin.c: Likewise.
* sysdeps/riscv/rvd/s_fpclassify.c: Likewise.
* sysdeps/riscv/rvd/s_isinf.c: Likewise.
* sysdeps/riscv/rvd/s_isnan.c: Likewise.
* sysdeps/riscv/rvd/s_issignaling.c: Likewise.
* sysdeps/riscv/rvf/fegetround.c: Likewise.
* sysdeps/riscv/rvf/feholdexcpt.c: Likewise.
* sysdeps/riscv/rvf/fesetenv.c: Likewise.
* sysdeps/riscv/rvf/fesetround.c: Likewise.
* sysdeps/riscv/rvf/feupdateenv.c: Likewise.
* sysdeps/riscv/rvf/fgetexcptflg.c: Likewise.
* sysdeps/riscv/rvf/ftestexcept.c: Likewise.
* sysdeps/riscv/rvf/s_ceilf.c: Likewise.
* sysdeps/riscv/rvf/s_finitef.c: Likewise.
* sysdeps/riscv/rvf/s_floorf.c: Likewise.
* sysdeps/riscv/rvf/s_fmaxf.c: Likewise.
* sysdeps/riscv/rvf/s_fminf.c: Likewise.
* sysdeps/riscv/rvf/s_fpclassifyf.c: Likewise.
* sysdeps/riscv/rvf/s_isinff.c: Likewise.
* sysdeps/riscv/rvf/s_isnanf.c: Likewise.
* sysdeps/riscv/rvf/s_issignalingf.c: Likewise.
* sysdeps/riscv/rvf/s_nearbyintf.c: Likewise.
* sysdeps/riscv/rvf/s_roundevenf.c: Likewise.
* sysdeps/riscv/rvf/s_roundf.c: Likewise.
* sysdeps/riscv/rvf/s_truncf.c: Likewise.
Diffstat (limited to 'sysdeps/riscv/rvf')
-rw-r--r-- | sysdeps/riscv/rvf/fegetround.c | 1 | ||||
-rw-r--r-- | sysdeps/riscv/rvf/feholdexcpt.c | 1 | ||||
-rw-r--r-- | sysdeps/riscv/rvf/fesetenv.c | 1 | ||||
-rw-r--r-- | sysdeps/riscv/rvf/fesetround.c | 1 | ||||
-rw-r--r-- | sysdeps/riscv/rvf/feupdateenv.c | 1 | ||||
-rw-r--r-- | sysdeps/riscv/rvf/fgetexcptflg.c | 1 | ||||
-rw-r--r-- | sysdeps/riscv/rvf/ftestexcept.c | 1 | ||||
-rw-r--r-- | sysdeps/riscv/rvf/s_ceilf.c | 1 | ||||
-rw-r--r-- | sysdeps/riscv/rvf/s_finitef.c | 1 | ||||
-rw-r--r-- | sysdeps/riscv/rvf/s_floorf.c | 1 | ||||
-rw-r--r-- | sysdeps/riscv/rvf/s_fmaxf.c | 1 | ||||
-rw-r--r-- | sysdeps/riscv/rvf/s_fminf.c | 1 | ||||
-rw-r--r-- | sysdeps/riscv/rvf/s_fpclassifyf.c | 1 | ||||
-rw-r--r-- | sysdeps/riscv/rvf/s_isinff.c | 1 | ||||
-rw-r--r-- | sysdeps/riscv/rvf/s_isnanf.c | 1 | ||||
-rw-r--r-- | sysdeps/riscv/rvf/s_issignalingf.c | 1 | ||||
-rw-r--r-- | sysdeps/riscv/rvf/s_nearbyintf.c | 1 | ||||
-rw-r--r-- | sysdeps/riscv/rvf/s_roundevenf.c | 1 | ||||
-rw-r--r-- | sysdeps/riscv/rvf/s_roundf.c | 1 | ||||
-rw-r--r-- | sysdeps/riscv/rvf/s_truncf.c | 1 |
20 files changed, 20 insertions, 0 deletions
diff --git a/sysdeps/riscv/rvf/fegetround.c b/sysdeps/riscv/rvf/fegetround.c index f7692a8..05397b1 100644 --- a/sysdeps/riscv/rvf/fegetround.c +++ b/sysdeps/riscv/rvf/fegetround.c @@ -18,6 +18,7 @@ #include <fenv.h> #include <math_private.h> +#include <fenv_private.h> int __fegetround (void) diff --git a/sysdeps/riscv/rvf/feholdexcpt.c b/sysdeps/riscv/rvf/feholdexcpt.c index ea9060f..96ac465 100644 --- a/sysdeps/riscv/rvf/feholdexcpt.c +++ b/sysdeps/riscv/rvf/feholdexcpt.c @@ -18,6 +18,7 @@ #include <fenv.h> #include <math_private.h> +#include <fenv_private.h> int __feholdexcept (fenv_t *envp) diff --git a/sysdeps/riscv/rvf/fesetenv.c b/sysdeps/riscv/rvf/fesetenv.c index 5d02d80..95ca4fe 100644 --- a/sysdeps/riscv/rvf/fesetenv.c +++ b/sysdeps/riscv/rvf/fesetenv.c @@ -18,6 +18,7 @@ #include <fenv.h> #include <math_private.h> +#include <fenv_private.h> int __fesetenv (const fenv_t *envp) diff --git a/sysdeps/riscv/rvf/fesetround.c b/sysdeps/riscv/rvf/fesetround.c index bf705ef..5bb237a 100644 --- a/sysdeps/riscv/rvf/fesetround.c +++ b/sysdeps/riscv/rvf/fesetround.c @@ -18,6 +18,7 @@ #include <fenv.h> #include <math_private.h> +#include <fenv_private.h> int __fesetround (int round) diff --git a/sysdeps/riscv/rvf/feupdateenv.c b/sysdeps/riscv/rvf/feupdateenv.c index 133d7ec..27ffa77 100644 --- a/sysdeps/riscv/rvf/feupdateenv.c +++ b/sysdeps/riscv/rvf/feupdateenv.c @@ -18,6 +18,7 @@ #include <fenv.h> #include <math_private.h> +#include <fenv_private.h> int __feupdateenv (const fenv_t *envp) diff --git a/sysdeps/riscv/rvf/fgetexcptflg.c b/sysdeps/riscv/rvf/fgetexcptflg.c index 367f013..f474269 100644 --- a/sysdeps/riscv/rvf/fgetexcptflg.c +++ b/sysdeps/riscv/rvf/fgetexcptflg.c @@ -18,6 +18,7 @@ #include <fenv.h> #include <math_private.h> +#include <fenv_private.h> int fegetexceptflag (fexcept_t *flagp, int excepts) diff --git a/sysdeps/riscv/rvf/ftestexcept.c b/sysdeps/riscv/rvf/ftestexcept.c index a248bd6..66bc9f9 100644 --- a/sysdeps/riscv/rvf/ftestexcept.c +++ b/sysdeps/riscv/rvf/ftestexcept.c @@ -18,6 +18,7 @@ #include <fenv.h> #include <math_private.h> +#include <fenv_private.h> int fetestexcept (int excepts) diff --git a/sysdeps/riscv/rvf/s_ceilf.c b/sysdeps/riscv/rvf/s_ceilf.c index d7e291a..a56f362 100644 --- a/sysdeps/riscv/rvf/s_ceilf.c +++ b/sysdeps/riscv/rvf/s_ceilf.c @@ -18,6 +18,7 @@ #include <math.h> #include <math_private.h> +#include <fenv_private.h> #include <libm-alias-float.h> #include <stdint.h> diff --git a/sysdeps/riscv/rvf/s_finitef.c b/sysdeps/riscv/rvf/s_finitef.c index 04ce087..4fd33b6 100644 --- a/sysdeps/riscv/rvf/s_finitef.c +++ b/sysdeps/riscv/rvf/s_finitef.c @@ -18,6 +18,7 @@ #include <math.h> #include <math_private.h> +#include <fenv_private.h> int __finitef (float x) diff --git a/sysdeps/riscv/rvf/s_floorf.c b/sysdeps/riscv/rvf/s_floorf.c index 3c9c625..560553f 100644 --- a/sysdeps/riscv/rvf/s_floorf.c +++ b/sysdeps/riscv/rvf/s_floorf.c @@ -18,6 +18,7 @@ #include <math.h> #include <math_private.h> +#include <fenv_private.h> #include <libm-alias-float.h> #include <stdint.h> diff --git a/sysdeps/riscv/rvf/s_fmaxf.c b/sysdeps/riscv/rvf/s_fmaxf.c index 63f7e3d..0496f7e 100644 --- a/sysdeps/riscv/rvf/s_fmaxf.c +++ b/sysdeps/riscv/rvf/s_fmaxf.c @@ -18,6 +18,7 @@ #include <math.h> #include <math_private.h> +#include <fenv_private.h> #include <libm-alias-float.h> float diff --git a/sysdeps/riscv/rvf/s_fminf.c b/sysdeps/riscv/rvf/s_fminf.c index 82cca4e..f963993 100644 --- a/sysdeps/riscv/rvf/s_fminf.c +++ b/sysdeps/riscv/rvf/s_fminf.c @@ -18,6 +18,7 @@ #include <math.h> #include <math_private.h> +#include <fenv_private.h> #include <libm-alias-float.h> float diff --git a/sysdeps/riscv/rvf/s_fpclassifyf.c b/sysdeps/riscv/rvf/s_fpclassifyf.c index 4abcf3e..ae4c492 100644 --- a/sysdeps/riscv/rvf/s_fpclassifyf.c +++ b/sysdeps/riscv/rvf/s_fpclassifyf.c @@ -18,6 +18,7 @@ #include <math.h> #include <math_private.h> +#include <fenv_private.h> int __fpclassifyf (float x) diff --git a/sysdeps/riscv/rvf/s_isinff.c b/sysdeps/riscv/rvf/s_isinff.c index 1c74131..621cdca 100644 --- a/sysdeps/riscv/rvf/s_isinff.c +++ b/sysdeps/riscv/rvf/s_isinff.c @@ -18,6 +18,7 @@ #include <math.h> #include <math_private.h> +#include <fenv_private.h> int __isinff (float x) diff --git a/sysdeps/riscv/rvf/s_isnanf.c b/sysdeps/riscv/rvf/s_isnanf.c index 30a88bb..cca3809 100644 --- a/sysdeps/riscv/rvf/s_isnanf.c +++ b/sysdeps/riscv/rvf/s_isnanf.c @@ -18,6 +18,7 @@ #include <math.h> #include <math_private.h> +#include <fenv_private.h> int __isnanf (float x) diff --git a/sysdeps/riscv/rvf/s_issignalingf.c b/sysdeps/riscv/rvf/s_issignalingf.c index e67efc7..846a7b7 100644 --- a/sysdeps/riscv/rvf/s_issignalingf.c +++ b/sysdeps/riscv/rvf/s_issignalingf.c @@ -18,6 +18,7 @@ #include <math.h> #include <math_private.h> +#include <fenv_private.h> int __issignalingf (float x) diff --git a/sysdeps/riscv/rvf/s_nearbyintf.c b/sysdeps/riscv/rvf/s_nearbyintf.c index d653794..80ff8a8 100644 --- a/sysdeps/riscv/rvf/s_nearbyintf.c +++ b/sysdeps/riscv/rvf/s_nearbyintf.c @@ -18,6 +18,7 @@ #include <math.h> #include <math_private.h> +#include <fenv_private.h> #include <libm-alias-float.h> #include <stdint.h> diff --git a/sysdeps/riscv/rvf/s_roundevenf.c b/sysdeps/riscv/rvf/s_roundevenf.c index 48086c2..afeebf2 100644 --- a/sysdeps/riscv/rvf/s_roundevenf.c +++ b/sysdeps/riscv/rvf/s_roundevenf.c @@ -18,6 +18,7 @@ #include <math.h> #include <math_private.h> +#include <fenv_private.h> #include <libm-alias-float.h> #include <stdint.h> diff --git a/sysdeps/riscv/rvf/s_roundf.c b/sysdeps/riscv/rvf/s_roundf.c index dedf57c..87839de 100644 --- a/sysdeps/riscv/rvf/s_roundf.c +++ b/sysdeps/riscv/rvf/s_roundf.c @@ -18,6 +18,7 @@ #include <math.h> #include <math_private.h> +#include <fenv_private.h> #include <libm-alias-float.h> #include <stdint.h> diff --git a/sysdeps/riscv/rvf/s_truncf.c b/sysdeps/riscv/rvf/s_truncf.c index e23926a..ad5c2e2 100644 --- a/sysdeps/riscv/rvf/s_truncf.c +++ b/sysdeps/riscv/rvf/s_truncf.c @@ -18,6 +18,7 @@ #include <math.h> #include <math_private.h> +#include <fenv_private.h> #include <libm-alias-float.h> #include <stdint.h> |