diff options
| author | Joseph Myers <joseph@codesourcery.com> | 2016-02-18 22:54:07 +0000 |
|---|---|---|
| committer | Joseph Myers <joseph@codesourcery.com> | 2016-02-18 22:54:07 +0000 |
| commit | 0fed79a8279bb4d4483895a742457946faf89594 (patch) | |
| tree | e4f4e236dd13cfe9d95a18981c7c7a8f395f571c /sysdeps/ieee754/ldbl-128ibm/e_fmodl.c | |
| parent | e2c631384a1f9795514d8a7303838070ea81e2ec (diff) | |
| download | glibc-0fed79a8279bb4d4483895a742457946faf89594.zip glibc-0fed79a8279bb4d4483895a742457946faf89594.tar.gz glibc-0fed79a8279bb4d4483895a742457946faf89594.tar.bz2 | |
Fix ldbl-128ibm fmodl handling of equal arguments with low part zero (bug 19602).
The ldbl-128ibm implementation of fmodl has logic to detect when the
first argument has absolute value less than or equal to the second.
This logic is only correct for nonzero low parts; if the high parts
are equal and the low parts are zero, then the signs of the low parts
(which have no semantic effect on the value of the long double number)
can result in equal values being wrongly treated as unequal, and an
incorrect result being returned from fmodl. This patch fixes this by
checking for the case of zero low parts.
Although this does show up in tests from libm-test.inc (both tests of
fmodl, and, indirectly, of remainderl / dreml), the dependence on
non-semantic zero low parts means that test shouldn't be expected to
reproduce it reliably; thus, this patch adds a standalone test that
sets up affected values using unions.
Tested for powerpc.
[BZ #19602]
* sysdeps/ieee754/ldbl-128ibm/e_fmodl.c (__ieee754_fmodl): Handle
equal high parts and both low parts zero specially.
* sysdeps/ieee754/ldbl-128ibm/test-fmodl-ldbl-128ibm.c: New test.
* sysdeps/ieee754/ldbl-128ibm/Makefile [$(subdir) = math] (tests):
Add test-fmodl-ldbl-128ibm.
Diffstat (limited to 'sysdeps/ieee754/ldbl-128ibm/e_fmodl.c')
| -rw-r--r-- | sysdeps/ieee754/ldbl-128ibm/e_fmodl.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/sysdeps/ieee754/ldbl-128ibm/e_fmodl.c b/sysdeps/ieee754/ldbl-128ibm/e_fmodl.c index d756e3e..5284fd0 100644 --- a/sysdeps/ieee754/ldbl-128ibm/e_fmodl.c +++ b/sysdeps/ieee754/ldbl-128ibm/e_fmodl.c @@ -55,6 +55,13 @@ __ieee754_fmodl (long double x, long double y) return x; /* At this point the absolute value of the high doubles of x and y must be equal. */ + if ((lx & 0x7fffffffffffffffLL) == 0 + && (ly & 0x7fffffffffffffffLL) == 0) + /* Both low parts are zero. The result should be an + appropriately signed zero, but the subsequent logic + could treat them as unequal, depending on the signs + of the low parts. */ + return Zero[(uint64_t) sx >> 63]; /* If the low double of y is the same sign as the high double of y (ie. the low double increases |y|)... */ if (((ly ^ sy) & 0x8000000000000000LL) == 0 |