diff options
| author | Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com> | 2017-06-26 09:55:41 -0300 |
|---|---|---|
| committer | Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com> | 2017-06-26 09:56:26 -0300 |
| commit | d54bb9b1d3fd25779fba2c403003c5097ba9af73 (patch) | |
| tree | e4529df0efdd8a7d0d23bf39a9fa87ac800fc1ea /malloc/tst-alloc_buffer.c | |
| parent | d9660db223630591739f3313b46faa5687eaf075 (diff) | |
| download | glibc-d54bb9b1d3fd25779fba2c403003c5097ba9af73.zip glibc-d54bb9b1d3fd25779fba2c403003c5097ba9af73.tar.gz glibc-d54bb9b1d3fd25779fba2c403003c5097ba9af73.tar.bz2 | |
Prevent an implicit int promotion in malloc/tst-alloc_buffer.c
According to ISO C11, section 6.5.3.3 "Unary arithmetic operators", the
result of the ~ operator is the bitwise complement of its (promoted)
operand.
This can lead to a comparison of a char with another integer type.
Tested on powerpc, powerpc64 and powerpc64le.
* malloc/tst-alloc_buffer.c (test_misaligned): Cast to char
before comparing with another char.
Diffstat (limited to 'malloc/tst-alloc_buffer.c')
| -rw-r--r-- | malloc/tst-alloc_buffer.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/malloc/tst-alloc_buffer.c b/malloc/tst-alloc_buffer.c index 1c14399..9b2bd20 100644 --- a/malloc/tst-alloc_buffer.c +++ b/malloc/tst-alloc_buffer.c @@ -429,7 +429,7 @@ test_misaligned (char pad) } /* Verify that padding was not overwritten. */ - TEST_VERIFY (backing[0] == ~pad); + TEST_VERIFY (backing[0] == (char) ~pad); TEST_VERIFY (backing[SIZE + 1] == pad); free (backing); } |