aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorUlrich Drepper <drepper@gmail.com>2011-07-02 12:30:03 -0400
committerUlrich Drepper <drepper@gmail.com>2011-07-02 12:30:03 -0400
commitfcfc776bc6242fdefde0efd7b0c315fbeca08555 (patch)
treec46c6b25047a2ed2f6baea7b76985f1d7bec3c4c
parent99231d9abe0fd74c7957d25b08c1d1ede4cae5a0 (diff)
downloadglibc-fcfc776bc6242fdefde0efd7b0c315fbeca08555.zip
glibc-fcfc776bc6242fdefde0efd7b0c315fbeca08555.tar.gz
glibc-fcfc776bc6242fdefde0efd7b0c315fbeca08555.tar.bz2
Optimize long-word additions in SHA implementation
-rw-r--r--ChangeLog14
-rw-r--r--crypt/sha256.c29
-rw-r--r--crypt/sha256.h8
-rw-r--r--crypt/sha512.c10
-rw-r--r--crypt/sha512.h14
5 files changed, 61 insertions, 14 deletions
diff --git a/ChangeLog b/ChangeLog
index 802b569..210bded 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,17 @@
+2011-07-02 Ulrich Drepper <drepper@gmail.com>
+
+ * crypt/sha512.h (struct sha512_ctx): Add union to access total also
+ as 128-bit value.
+ * crypt/sha512.c (sha512_process_block): Perform total addition using
+ 128-bit if possible.
+ (__sha512_finish_ctx): Likewise.
+ * crypt/sha256.h (struct sha256_ctx): Add union to access total also
+ as 64-bit value.
+ * crypt/sha256.c (SWAP64): Define.
+ (sha256_process_block): Perform total addition using 64-bit if
+ possible.
+ (__sha256_finish_ctx): Likewise.
+
2011-07-01 Ulrich Drepper <drepper@gmail.com>
* nscd/pwdcache.c (cache_addpw): Cleanup. Add branch prediction.
diff --git a/crypt/sha256.c b/crypt/sha256.c
index 941612e..0ca3355 100644
--- a/crypt/sha256.c
+++ b/crypt/sha256.c
@@ -1,6 +1,6 @@
/* Functions to compute SHA256 message digest of files or memory blocks.
according to the definition of SHA256 in FIPS 180-2.
- Copyright (C) 2007 Free Software Foundation, Inc.
+ Copyright (C) 2007, 2011 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
@@ -35,12 +35,23 @@
# ifdef _LIBC
# include <byteswap.h>
# define SWAP(n) bswap_32 (n)
+# define SWAP64(n) bswap_64 (n)
# else
# define SWAP(n) \
(((n) << 24) | (((n) & 0xff00) << 8) | (((n) >> 8) & 0xff00) | ((n) >> 24))
+# define SWAP64(n) \
+ (((n) << 56) \
+ | (((n) & 0xff00) << 40) \
+ | (((n) & 0xff0000) << 24) \
+ | (((n) & 0xff000000) << 8) \
+ | (((n) >> 8) & 0xff000000) \
+ | (((n) >> 24) & 0xff0000) \
+ | (((n) >> 40) & 0xff00) \
+ | ((n) >> 56))
# endif
#else
# define SWAP(n) (n)
+# define SWAP64(n) (n)
#endif
@@ -89,10 +100,8 @@ sha256_process_block (const void *buffer, size_t len, struct sha256_ctx *ctx)
/* First increment the byte count. FIPS 180-2 specifies the possible
length of the file up to 2^64 bits. Here we only compute the
- number of bytes. Do a double word increment. */
- ctx->total[0] += len;
- if (ctx->total[0] < len)
- ++ctx->total[1];
+ number of bytes. */
+ ctx->total64 += len;
/* Process all bytes in the buffer with 64 bytes in each round of
the loop. */
@@ -186,7 +195,7 @@ __sha256_init_ctx (ctx)
ctx->H[6] = 0x1f83d9ab;
ctx->H[7] = 0x5be0cd19;
- ctx->total[0] = ctx->total[1] = 0;
+ ctx->total64 = 0;
ctx->buflen = 0;
}
@@ -206,17 +215,19 @@ __sha256_finish_ctx (ctx, resbuf)
size_t pad;
/* Now count remaining bytes. */
- ctx->total[0] += bytes;
- if (ctx->total[0] < bytes)
- ++ctx->total[1];
+ ctx->total64 += bytes;
pad = bytes >= 56 ? 64 + 56 - bytes : 56 - bytes;
memcpy (&ctx->buffer[bytes], fillbuf, pad);
/* Put the 64-bit file length in *bits* at the end of the buffer. */
+#ifdef _STRING_ARCH_unaligned
+ *(uint64_t *) &ctx->buffer[bytes + pad] = SWAP64 (ctx->total64 << 3);
+#else
*(uint32_t *) &ctx->buffer[bytes + pad + 4] = SWAP (ctx->total[0] << 3);
*(uint32_t *) &ctx->buffer[bytes + pad] = SWAP ((ctx->total[1] << 3) |
(ctx->total[0] >> 29));
+#endif
/* Process last bytes. */
sha256_process_block (ctx->buffer, bytes + pad + 8, ctx);
diff --git a/crypt/sha256.h b/crypt/sha256.h
index be8b077..fcf6148 100644
--- a/crypt/sha256.h
+++ b/crypt/sha256.h
@@ -1,6 +1,6 @@
/* Declaration of functions and data types used for SHA256 sum computing
library functions.
- Copyright (C) 2007 Free Software Foundation, Inc.
+ Copyright (C) 2007, 2011 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
@@ -31,7 +31,11 @@ struct sha256_ctx
{
uint32_t H[8];
- uint32_t total[2];
+ union
+ {
+ uint64_t total64;
+ uint32_t total[2];
+ };
uint32_t buflen;
char buffer[128] __attribute__ ((__aligned__ (__alignof__ (uint32_t))));
};
diff --git a/crypt/sha512.c b/crypt/sha512.c
index 0212747..16b4877 100644
--- a/crypt/sha512.c
+++ b/crypt/sha512.c
@@ -1,6 +1,6 @@
/* Functions to compute SHA512 message digest of files or memory blocks.
according to the definition of SHA512 in FIPS 180-2.
- Copyright (C) 2007 Free Software Foundation, Inc.
+ Copyright (C) 2007, 2011 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
@@ -121,9 +121,13 @@ sha512_process_block (const void *buffer, size_t len, struct sha512_ctx *ctx)
/* First increment the byte count. FIPS 180-2 specifies the possible
length of the file up to 2^128 bits. Here we only compute the
number of bytes. Do a double word increment. */
+#ifdef USE_TOTAL128
+ ctx->total128 += len;
+#else
ctx->total[0] += len;
if (ctx->total[0] < len)
++ctx->total[1];
+#endif
/* Process all bytes in the buffer with 128 bytes in each round of
the loop. */
@@ -237,9 +241,13 @@ __sha512_finish_ctx (ctx, resbuf)
size_t pad;
/* Now count remaining bytes. */
+#ifdef USE_TOTAL128
+ ctx->total128 += bytes;
+#else
ctx->total[0] += bytes;
if (ctx->total[0] < bytes)
++ctx->total[1];
+#endif
pad = bytes >= 112 ? 128 + 112 - bytes : 112 - bytes;
memcpy (&ctx->buffer[bytes], fillbuf, pad);
diff --git a/crypt/sha512.h b/crypt/sha512.h
index 9952c5f..90e55dc 100644
--- a/crypt/sha512.h
+++ b/crypt/sha512.h
@@ -1,6 +1,6 @@
/* Declaration of functions and data types used for SHA512 sum computing
library functions.
- Copyright (C) 2007 Free Software Foundation, Inc.
+ Copyright (C) 2007, 2011 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
@@ -24,6 +24,9 @@
#include <limits.h>
#include <stdint.h>
#include <stdio.h>
+#ifdef _LIBC
+# include <bits/wordsize.h>
+#endif
/* Structure to save state of computation between the single steps. */
@@ -31,7 +34,14 @@ struct sha512_ctx
{
uint64_t H[8];
- uint64_t total[2];
+ union
+ {
+#if defined __GNUC__ && __WORDSIZE == 64
+# define USE_TOTAL128
+ unsigned int total128 __attribute__ ((__mode__ (TI)));
+#endif
+ uint64_t total[2];
+ };
uint64_t buflen;
char buffer[256] __attribute__ ((__aligned__ (__alignof__ (uint64_t))));
};