aboutsummaryrefslogtreecommitdiff
path: root/sim/sh
diff options
context:
space:
mode:
authorTom Tromey <tom@tromey.com>2018-08-18 14:51:46 -0600
committerTom Tromey <tom@tromey.com>2018-10-03 15:19:06 -0600
commit5e70ee0905a848701bb929a66f84ff2e212cfa81 (patch)
tree4d059f190de82f740bff0eb9b77d5ddf0c38c454 /sim/sh
parent4dd1b46077b2ae7331f274f7888733de5166445c (diff)
downloadgdb-5e70ee0905a848701bb929a66f84ff2e212cfa81.zip
gdb-5e70ee0905a848701bb929a66f84ff2e212cfa81.tar.gz
gdb-5e70ee0905a848701bb929a66f84ff2e212cfa81.tar.bz2
Avoid undefined behavior in ada_operator_length
-fsanitize=undefined pointed out this error: runtime error: load of value 2887952, which is not a valid value for type 'exp_opcode' This happens in gdb.ada/complete.exp when processing "complete p my_glob". This does not parse, so the Ada parser throws an exception; but then the code in parse_exp_in_context_1 accepts the expression anyway. However, as no elements have been written to the expression, undefined behavior results. The fix is to notice this case in parse_exp_in_context_1. This patch also adds an assertion to prefixify_expression to enforce this pre-existing constraint. gdb/ChangeLog 2018-10-03 Tom Tromey <tom@tromey.com> * parse.c (prefixify_expression): Add assert. (parse_exp_in_context_1): Throw exception if the expression is empty.
Diffstat (limited to 'sim/sh')
0 files changed, 0 insertions, 0 deletions