diff options
| author | Mike Frysinger <vapier@gentoo.org> | 2015-12-26 07:05:41 -0500 |
|---|---|---|
| committer | Mike Frysinger <vapier@gentoo.org> | 2015-12-26 07:19:07 -0500 |
| commit | 0e9672991e9346d5c2cb9cd33e30fb3e573f88b8 (patch) | |
| tree | b9a00b51355ac7ebed43ebf97f78b7a373b42936 /sim/ft32 | |
| parent | f66affe97c40465e70249970b3339cc2f0a40e69 (diff) | |
| download | gdb-0e9672991e9346d5c2cb9cd33e30fb3e573f88b8.zip gdb-0e9672991e9346d5c2cb9cd33e30fb3e573f88b8.tar.gz gdb-0e9672991e9346d5c2cb9cd33e30fb3e573f88b8.tar.bz2 | |
sim: standardize sim_create_inferior handling of argv a bit more
For targets that process argv in sim_create_inferior, improve the code:
- provide more details in the comment
- make the check for when to re-init more robust
- clean out legacy sim_copy_argv code
This will be cleaned up more in the future when we have a common inferior
creation function, but at least help new ports get it right until then.
Diffstat (limited to 'sim/ft32')
| -rw-r--r-- | sim/ft32/ChangeLog | 4 | ||||
| -rw-r--r-- | sim/ft32/interp.c | 6 |
2 files changed, 9 insertions, 1 deletions
diff --git a/sim/ft32/ChangeLog b/sim/ft32/ChangeLog index a306ffe..b246467 100644 --- a/sim/ft32/ChangeLog +++ b/sim/ft32/ChangeLog @@ -1,3 +1,7 @@ +2015-12-26 Mike Frysinger <vapier@gentoo.org> + + * interp.c (sim_create_inferior): Update comment and argv check. + 2015-11-15 Mike Frysinger <vapier@gentoo.org> * Makefile.in (SIM_OBJS): Delete sim-reason.o, sim-reg.o, and diff --git a/sim/ft32/interp.c b/sim/ft32/interp.c index e2762b8..63ce77b 100644 --- a/sim/ft32/interp.c +++ b/sim/ft32/interp.c @@ -877,7 +877,11 @@ sim_create_inferior (SIM_DESC sd, else addr = 0; - if (STATE_OPEN_KIND (sd) == SIM_OPEN_DEBUG) + /* Standalone mode (i.e. `run`) will take care of the argv for us in + sim_open() -> sim_parse_args(). But in debug mode (i.e. 'target sim' + with `gdb`), we need to handle it because the user can change the + argv on the fly via gdb's 'run'. */ + if (STATE_PROG_ARGV (sd) != argv) { freeargv (STATE_PROG_ARGV (sd)); STATE_PROG_ARGV (sd) = dupargv (argv); |