diff options
author | Nick Alcock <nick.alcock@oracle.com> | 2024-06-19 14:06:26 +0100 |
---|---|---|
committer | Nick Alcock <nick.alcock@oracle.com> | 2024-06-19 15:51:24 +0100 |
commit | b84ffc176d3ab90a5dd42e406f84b2207f2782ca (patch) | |
tree | 7fb14515c901b47af902f63096bd9d75fced6343 /libctf/testsuite/libctf-lookup/enumerator-iteration.c | |
parent | ea4e03c0a9f5ed8574dcaa434cd979a6f92f5c1f (diff) | |
download | gdb-b84ffc176d3ab90a5dd42e406f84b2207f2782ca.zip gdb-b84ffc176d3ab90a5dd42e406f84b2207f2782ca.tar.gz gdb-b84ffc176d3ab90a5dd42e406f84b2207f2782ca.tar.bz2 |
libctf: fix testsuite bugs revealed by -Wall
Most of these are harmless, but some of the type confusions and especially
a missing ctf_strerror() on an error path were actual bugs that could
have resulted in test failures crashing rather than printing an error
message.
libctf/
* testsuite/libctf-lookup/enumerator-iteration.c: Fix type
confusion, signedness confusion and a missing ctf_errmsg().
* testsuite/libctf-regression/libctf-repeat-cu-main.c: Return 0 from
the test function.
* testsuite/libctf-regression/open-error-free.c: Fix signedness
confusion.
* testsuite/libctf-regression/zrewrite.c: Remove unused label.
Diffstat (limited to 'libctf/testsuite/libctf-lookup/enumerator-iteration.c')
-rw-r--r-- | libctf/testsuite/libctf-lookup/enumerator-iteration.c | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/libctf/testsuite/libctf-lookup/enumerator-iteration.c b/libctf/testsuite/libctf-lookup/enumerator-iteration.c index e46dad6..78cb5a3 100644 --- a/libctf/testsuite/libctf-lookup/enumerator-iteration.c +++ b/libctf/testsuite/libctf-lookup/enumerator-iteration.c @@ -23,8 +23,8 @@ print_constants (ctf_archive_t *ctf, const char *name) { char *foo; - printf ("%s in %s has value %i\n", name, - foo = ctf_type_aname (fp, type), val); + printf ("%s in %s has value %li\n", name, + foo = ctf_type_aname (fp, type), (long int) val); free (foo); ctf_dict_close (fp); @@ -44,7 +44,6 @@ main (int argc, char *argv[]) int err; ctf_id_t type; ctf_next_t *i = NULL; - const char *name; int64_t val; int counter = 0; @@ -71,8 +70,8 @@ main (int argc, char *argv[]) { char *foo; - printf ("IENUMSAMPLE2_2 in %s has value %i\n", - foo = ctf_type_aname (fp, type), val); + printf ("IENUMSAMPLE2_2 in %s has value %li\n", + foo = ctf_type_aname (fp, type), (long int) val); free (foo); if ((type = ctf_add_enum (fp, CTF_ADD_ROOT, "ie3")) == CTF_ERR) @@ -117,13 +116,13 @@ main (int argc, char *argv[]) if (type != CTF_ERR) { char *foo; - printf ("direct lookup: hidden lookup did not return ECTF_NOENUMNAM but rather %i in %s\n", - val, foo = ctf_type_aname (fp, type)); + printf ("direct lookup: hidden lookup did not return ECTF_NOENUMNAM but rather %li in %s\n", + (long int) val, foo = ctf_type_aname (fp, type)); free (foo); } else printf ("direct lookup: hidden lookup did not return ECTF_NOENUMNAM but rather %s\n", - ctf_errno (fp)); + ctf_errmsg (ctf_errno (fp))); } ctf_dict_close (fp); |