PR 33917 Internal error in S_SET_SEGMENTHEADmaster

Commit d4d05d13eba6 attempted to fix a similar error to that uncovered
by the testcase in pr33917, but did so in a way that was wrong.
Modifying an undefined_section symbol that is an equate breaks prior
use of that symbol, as shown in the rewrite of the
section-symbol-redef test.

Another oddity found when poking at pr33917 is that gas allows
 x=0
 .sect x
 x=u
while
 .sect x
 x=u
fails with "Error: symbol `x' is already defined".

Fix all of this by rewriting section_symbol to properly check for the
only case where we want to redefine an existing symbol, a truly
undefined symbol, and always use section_symbol in obj-elf rather than
trying to handle undefined symbols there too.

	PR 33917
	* config/obj-elf.c (change_section): Always call section_symbol
	to set up sym.
	* subsegs.c (section_symbol): Rewrite.
	* testsuite/gas/elf/section-symbol-redef.d
	* testsuite/gas/elf/section-symbol-redef.s: Rewrite.
	* testsuite/gas/elf/section-symbol-redef-2.d,
	* testsuite/gas/elf/section-symbol-redef-2.s: New test.
	* testsuite/gas/elf/elf.exp: Run new test.

0 files changed, 0 insertions, 0 deletions