diff options
| author | Alan Modra <amodra@gmail.com> | 2024-02-15 19:03:07 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2024-02-15 19:11:42 +1030 |
| commit | 313f04b6edcd09e0e7ff224bd54a892ab8f029aa (patch) | |
| tree | b7a16c713a410489aeec144fb73106b193d10254 /ld/ldwrite.c | |
| parent | d88a48558d6dc171fccb4c5c496c9248e78eecd0 (diff) | |
| download | gdb-313f04b6edcd09e0e7ff224bd54a892ab8f029aa.zip gdb-313f04b6edcd09e0e7ff224bd54a892ab8f029aa.tar.gz gdb-313f04b6edcd09e0e7ff224bd54a892ab8f029aa.tar.bz2 | |
Re: elf_backend_finish_dynamic_symbol returning false
I didn't examine ld testsuite logs properly after cf95b909e2c2.
Replacing one of the "return false" with BFD_ASSERT in
finish_dynamic_symbol was wrong as it causes segmentation faults on
testcases expected to fail. Revert those changes and instead make
a bfd_final_link failure noisy.
Diffstat (limited to 'ld/ldwrite.c')
| -rw-r--r-- | ld/ldwrite.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/ld/ldwrite.c b/ld/ldwrite.c index 46fb33c..8ce4297 100644 --- a/ld/ldwrite.c +++ b/ld/ldwrite.c @@ -549,13 +549,9 @@ ldwrite (void) split_sections (link_info.output_bfd, &link_info); if (!bfd_final_link (link_info.output_bfd, &link_info)) { - /* If there was an error recorded, print it out. Otherwise assume - an appropriate error message like unknown symbol was printed - out. */ - if (bfd_get_error () != bfd_error_no_error) einfo (_("%F%P: final link failed: %E\n")); else - xexit (1); + einfo (_("%F%P: final link failed\n")); } } |