aboutsummaryrefslogtreecommitdiff
path: root/gold/symtab.h
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2019-10-02 10:41:01 +0930
committerAlan Modra <amodra@gmail.com>2019-11-19 07:36:20 +1030
commitaa465b19c80b660b4d4fe6608fb66ebeb469f38b (patch)
treedb8c348a1928f2ad30917daaf2234cb0542b8eb2 /gold/symtab.h
parent94698d0198f4018b2ac248b248868cb7a5c0cc43 (diff)
downloadgdb-aa465b19c80b660b4d4fe6608fb66ebeb469f38b.zip
gdb-aa465b19c80b660b4d4fe6608fb66ebeb469f38b.tar.gz
gdb-aa465b19c80b660b4d4fe6608fb66ebeb469f38b.tar.bz2
[GOLD] OSABI not set when STT_GNU_IFUNC or STB_GNU_UNIQUE symbols output
This patch arranges to have OSABI set to ELFOSABI_GNU (if not set to some other non-zero value) when gold outputs an ifunc local or global symbol, or a unique global symbol to either .dynsym or .symtab. STT_GNU_IFUNC and STB_GNU_UNIQUE have values in the LOOS to HIOS range and therefore require interpretation according to OSABI. I'm not sure why parameters->target() is const Target& while parameters->sized_target() is Sized_target*, but it's inconvenient to use the latter in Symbol_table::finalize. So this patch adds another const_cast complained about in layout.cc and gold.cc. PR 24853 * symtab.h (set_has_gnu_output, has_gnu_output_): New. * symtab.cc (Symbol_table::Symbol_table): Init has_gnu_output_. (Symbol_table::finalize): Set ELFOSABI_GNU when has_gnu_output_. (Symbol_table::set_dynsym_indexes, Symbol_table::sized_finalize): Call set_has_gnu_output for STT_GNU_IFUNC and STB_GNU_UNIQUE globals. * object.cc (Sized_relobj_file::do_finalize_local_symbols): Call set_has_gnu_output when STT_GNU_IFUNC locals will be output.
Diffstat (limited to 'gold/symtab.h')
-rw-r--r--gold/symtab.h6
1 files changed, 6 insertions, 0 deletions
diff --git a/gold/symtab.h b/gold/symtab.h
index a9e8dd3..dd931f5 100644
--- a/gold/symtab.h
+++ b/gold/symtab.h
@@ -1580,6 +1580,10 @@ class Symbol_table
saw_undefined() const
{ return this->saw_undefined_; }
+ void
+ set_has_gnu_output()
+ { this->has_gnu_output_ = true; }
+
// Allocate the common symbols
void
allocate_commons(Layout*, Mapfile*);
@@ -1981,6 +1985,8 @@ class Symbol_table
// The number of global dynamic symbols (including forced-local symbols),
// or 0 if none.
unsigned int dynamic_count_;
+ // Set if a STT_GNU_IFUNC or STB_GNU_UNIQUE symbol will be output.
+ bool has_gnu_output_;
// The symbol hash table.
Symbol_table_type table_;
// A pool of symbol names. This is used for all global symbols.