diff options
| author | Tom de Vries <tdevries@suse.de> | 2020-06-29 13:59:19 +0200 |
|---|---|---|
| committer | Tom de Vries <tdevries@suse.de> | 2020-06-29 13:59:19 +0200 |
| commit | a3ca48cdda743dc2756e8c689feab67273969db0 (patch) | |
| tree | 3f6e219a23487a247a82178b3836a60514bf7557 /gdb | |
| parent | f638ed73010c667c86714b3435a5e1f3a06521cd (diff) | |
| download | gdb-a3ca48cdda743dc2756e8c689feab67273969db0.zip gdb-a3ca48cdda743dc2756e8c689feab67273969db0.tar.gz gdb-a3ca48cdda743dc2756e8c689feab67273969db0.tar.bz2 | |
[gdb/testsuite] Emit unresolved for unknown proc
Since commit 26783bce15 "[gdb/testsuite] Don't abort testrun for invalid
command in test-case" we don't abort the testrun when encountering an invalid
command. However, since we don't report errors in the summary, there's a
chance that the error goes unnoticed.
Make the invalid command error more visible by marking the test-case
unresolved, such that we have f.i.:
...
PASS: gdb.python/py-breakpoint.exp: test_bkpt_internal: Test watchpoint write
UNRESOLVED: gdb.python/py-breakpoint.exp: test_bkpt_eval_funcs: \
testcase aborted due to invalid command name: gdb_py_test_multiple
ERROR: tcl error sourcing py-breakpoint.exp.
ERROR: invalid command name "gdb_py_test_multiple"
while executing
...
=== gdb Summary ===
nr of expected passes 56
nr of unresolved testcases 1
...
Tested on x86_64-linux.
gdb/testsuite/ChangeLog:
2020-06-29 Tom de Vries <tdevries@suse.de>
* lib/gdb.exp (unknown): Make test-case unresolved.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/testsuite/ChangeLog | 4 | ||||
| -rw-r--r-- | gdb/testsuite/lib/gdb.exp | 2 |
2 files changed, 6 insertions, 0 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 0c2f47b..8001ec1 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,9 @@ 2020-06-29 Tom de Vries <tdevries@suse.de> + * lib/gdb.exp (unknown): Make test-case unresolved. + +2020-06-29 Tom de Vries <tdevries@suse.de> + PR gdb/25475 * gdb.server/solib-list.exp: Verify that the symbol reload confirmation question is asked. diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index af3e02d..b0faf62 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -5103,6 +5103,8 @@ proc default_gdb_init { test_file_name } { rename ::unknown ::dejagnu_unknown proc unknown { args } { # Use tcl's unknown. + set cmd [lindex $args 0] + unresolved "testcase aborted due to invalid command name: $cmd" return [uplevel 1 ::gdb_tcl_unknown $args] } } |