aboutsummaryrefslogtreecommitdiff
path: root/gdb
diff options
context:
space:
mode:
authorTom Tromey <tom@tromey.com>2022-04-05 14:43:30 -0600
committerTom Tromey <tom@tromey.com>2022-04-06 14:16:07 -0600
commit8fb105930851c7a722b4794f8348f72f29721cd0 (patch)
tree6eb7f14c9acc54476f20878ba624fae32385fc99 /gdb
parent6d088eb92ee42e05a4fbe797515229cf2acd0d99 (diff)
downloadgdb-8fb105930851c7a722b4794f8348f72f29721cd0.zip
gdb-8fb105930851c7a722b4794f8348f72f29721cd0.tar.gz
gdb-8fb105930851c7a722b4794f8348f72f29721cd0.tar.bz2
Use new and delete in jit.c
This changes jit.c to use new and delete, rather than XCNEW. This simplifies the code a little. This was useful for another patch I'm working on, and I thought it would make sense to send it separately. Regression tested on x86-64 Fedora 34.
Diffstat (limited to 'gdb')
-rw-r--r--gdb/jit.c17
1 files changed, 7 insertions, 10 deletions
diff --git a/gdb/jit.c b/gdb/jit.c
index a727143..342b0d0 100644
--- a/gdb/jit.c
+++ b/gdb/jit.c
@@ -935,7 +935,7 @@ struct jit_unwind_private
{
/* Cached register values. See jit_frame_sniffer to see how this
works. */
- detached_regcache *regcache;
+ std::unique_ptr<detached_regcache> regcache;
/* The frame being unwound. */
struct frame_info *this_frame;
@@ -1002,10 +1002,7 @@ static void
jit_dealloc_cache (struct frame_info *this_frame, void *cache)
{
struct jit_unwind_private *priv_data = (struct jit_unwind_private *) cache;
-
- gdb_assert (priv_data->regcache != NULL);
- delete priv_data->regcache;
- xfree (priv_data);
+ delete priv_data;
}
/* The frame sniffer for the pseudo unwinder.
@@ -1035,11 +1032,11 @@ jit_frame_sniffer (const struct frame_unwind *self,
gdb_assert (!*cache);
- *cache = XCNEW (struct jit_unwind_private);
- priv_data = (struct jit_unwind_private *) *cache;
+ priv_data = new struct jit_unwind_private;
+ *cache = priv_data;
/* Take a snapshot of current regcache. */
- priv_data->regcache = new detached_regcache (get_frame_arch (this_frame),
- true);
+ priv_data->regcache.reset
+ (new detached_regcache (get_frame_arch (this_frame), true));
priv_data->this_frame = this_frame;
callbacks.priv_data = priv_data;
@@ -1072,7 +1069,7 @@ jit_frame_this_id (struct frame_info *this_frame, void **cache,
struct gdb_reader_funcs *funcs;
struct gdb_unwind_callbacks callbacks;
- priv.regcache = NULL;
+ priv.regcache.reset ();
priv.this_frame = this_frame;
/* We don't expect the frame_id function to set any registers, so we